Deprecate to_values and from_values and use to_coo and from_coo #293

Activity

1. eriknw

   added

   deprecationSomething is being removedSomething is being removed

   ioData input, output, and conversionsData input, output, and conversions

   on Oct 19, 2022
2. eriknw commented on Oct 27, 2022

   

   eriknw

   on Oct 27, 2022

   MemberAuthor

   More actions

   @jim22k and I discussed this today, and we think we should very gently deprecate to_values and from_values.

   Step 1 is to remove usage and reference of to_values in code and documentation and use to_coo instead, and mention to_values will be become deprecated in its docstring. Also, mention the pending deprecation in release notes.

   Step 2 is to give a deprecation warning. Maybe do this in a few months

   Step 3 is to remove it. Maybe in a year.

   @jim22k, should we rename Vector.from_values and v.to_values? from_coo? to_sparse?
3. jim22k commented on Oct 27, 2022

   

   jim22k

   on Oct 27, 2022

   Member

   More actions

   Maybe we leave Vectors as from_values. I'm struggling to come up with something better. COO could work. I don't love Sparse, even though that is what the format is called internally in suitesparse.
4. eriknw

   changed the title [-]Should we deprecate `to_values` and `from_values` and use `to_coo` and `from_coo`?[/-] [+]Deprecate `to_values` and `from_values` and use `to_coo` and `from_coo`[/+] on Nov 14, 2022
5. eriknw commented on Nov 14, 2022

   

   eriknw

   on Nov 14, 2022

   MemberAuthor

   More actions

   I'm in favor of deprecating Vector.from_values and using Vector.from_coo instead.
6. eriknw commented on Nov 17, 2022

   

   eriknw

   on Nov 17, 2022

   MemberAuthor

   More actions

   Closed by #331
7. eriknw

   closed this as completedon Nov 17, 2022