Skip to content

indexunary is missing helpers value, row, column, and index #239

New issue
New issue
Open
Open
indexunary is missing helpers value, row, column, and index#239
Labels
enhancementImprove existing functionality or make things work betterfeatureSomething is missinggood first issueClearly described and easy to accomplish. Good for beginners to the project.good second issueClearly described, educational, but less trivial than "good first issue".

Description

@eriknw
eriknw
opened on May 21, 2022

I see no reason why these shouldn't exist in indexunary namespace. Any reason for their omission @jim22k?

Also, I noticed that select and indexunary are both directories with a single __init__.py. Unless we expect to put more files in these (such as numpy.py), I would change these to select.py and indexunary.py.

Activity

  1. eriknw
    added
    enhancementImprove existing functionality or make things work better
    featureSomething is missing
    on May 21, 2022

  2. jim22k commented on May 21, 2022

    @jim22k
    jim22k
    on May 21, 2022
    Member

    Just an assumption that they wouldn't be used much if at all in indexunary, so I didn't include them. I'm not opposed to someone adding them.

  3. eriknw commented on May 21, 2022

    @eriknw
    eriknw
    on May 21, 2022
    MemberAuthor

    Gotcha. I was playing around with mask recipes (shocking, I know), and one recipe for m1 as value mask (such as A.V) and m2 as any other mask is:

    val = indexunary.valuene(m1.parent, False).new(dtype, mask=m2)
val(val.V, replace=True) << True  # or select.nonzero

    And I was surprised that the indexunary.value helper wasn't there.

  4. eriknw
    added
    good first issueClearly described and easy to accomplish. Good for beginners to the project.
    good second issueClearly described, educational, but less trivial than "good first issue".
    on May 21, 2022
  5. eriknw
    added a commit that references this issue on Aug 5, 2026

    Add indexunary.value/row/column helpers accepting comparison expressi…

    3379d9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementImprove existing functionality or make things work betterfeatureSomething is missinggood first issueClearly described and easy to accomplish. Good for beginners to the project.good second issueClearly described, educational, but less trivial than "good first issue".

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions