From 71d4b32960e6b4c764f0c9d4e1b18a02812194f9 Mon Sep 17 00:00:00 2001 From: "Scott C. Livingston" Date: Tue, 27 Oct 2026 23:20:47 -0700 Subject: [PATCH 1/3] CI: use miniforge in install_examples workflow --- .github/conda-env/example-env.yml | 10 ++++++++++ .github/workflows/install_examples.yml | 25 ++++++++++++------------- 2 files changed, 22 insertions(+), 13 deletions(-) create mode 100644 .github/conda-env/example-env.yml diff --git a/.github/conda-env/example-env.yml b/.github/conda-env/example-env.yml new file mode 100644 index 000000000..d17b6722e --- /dev/null +++ b/.github/conda-env/example-env.yml @@ -0,0 +1,10 @@ +name: control-examples-env +dependencies: + - pip + - numpy + - matplotlib + - scipy + - slycot + - pmw + - jupyter + - ipython!=9.0 diff --git a/.github/workflows/install_examples.yml b/.github/workflows/install_examples.yml index 6893a99fb..8e5efba8d 100644 --- a/.github/workflows/install_examples.yml +++ b/.github/workflows/install_examples.yml @@ -9,19 +9,18 @@ jobs: steps: - name: Check out the python-control sources uses: actions/checkout@v3 - - name: Set up conda using the preinstalled GHA Miniconda - run: echo $CONDA/bin >> $GITHUB_PATH - - name: Install Python dependencies from conda-forge - run: | - conda create \ - --name control-examples-env \ - --channel conda-forge \ - --strict-channel-priority \ - --quiet --yes \ - python=3.12 pip \ - numpy matplotlib scipy \ - slycot pmw jupyter \ - ipython!=9.0 + + - name: Setup Conda + uses: conda-incubator/setup-miniconda@v3 + with: + python-version: 3.12 + activate-environment: control-examples-env + environment-file: .github/conda-env/example-env.yml + miniforge-version: latest + channels: conda-forge,defaults + channel-priority: strict + auto-update-conda: false + auto-activate-base: false - name: Install from source run: | From c1e742a14002f46dea66ffc61b07929699794b69 Mon Sep 17 00:00:00 2001 From: "Scott C. Livingston" Date: Tue, 27 Oct 2026 23:47:35 -0700 Subject: [PATCH 2/3] CI: update checkout and setup-python actions motivated because Node.js 20 is deprecated, https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/ and CI jobs had warnings: > The following actions target Node.js 20 but are being forced to run on Node.js 24 --- .github/workflows/control-slycot-src.yml | 6 +++--- .github/workflows/doctest.yml | 2 +- .github/workflows/install_examples.yml | 2 +- .github/workflows/os-blas-test-matrix.yml | 20 ++++++++++---------- .github/workflows/python-package-conda.yml | 2 +- .github/workflows/ruff-check.yml | 4 ++-- 6 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/workflows/control-slycot-src.yml b/.github/workflows/control-slycot-src.yml index 2506c4993..7c745704c 100644 --- a/.github/workflows/control-slycot-src.yml +++ b/.github/workflows/control-slycot-src.yml @@ -8,18 +8,18 @@ jobs: steps: - name: Checkout python-control - uses: actions/checkout@v3 + uses: actions/checkout@v7 with: path: python-control - name: Set up Python - uses: actions/setup-python@v4 + uses: actions/setup-python@v7 with: python-version: '3.12' - name: Install Python dependencies and test tools run: pip install -v './python-control[test]' - name: Checkout Slycot - uses: actions/checkout@v3 + uses: actions/checkout@v7 with: repository: python-control/Slycot submodules: recursive diff --git a/.github/workflows/doctest.yml b/.github/workflows/doctest.yml index 590d4a97f..d46d26857 100644 --- a/.github/workflows/doctest.yml +++ b/.github/workflows/doctest.yml @@ -10,7 +10,7 @@ jobs: steps: - name: Checkout python-control - uses: actions/checkout@v3 + uses: actions/checkout@v7 - name: Setup Conda uses: conda-incubator/setup-miniconda@v3 diff --git a/.github/workflows/install_examples.yml b/.github/workflows/install_examples.yml index 8e5efba8d..91a1aa304 100644 --- a/.github/workflows/install_examples.yml +++ b/.github/workflows/install_examples.yml @@ -8,7 +8,7 @@ jobs: steps: - name: Check out the python-control sources - uses: actions/checkout@v3 + uses: actions/checkout@v7 - name: Setup Conda uses: conda-incubator/setup-miniconda@v3 diff --git a/.github/workflows/os-blas-test-matrix.yml b/.github/workflows/os-blas-test-matrix.yml index 3661c0499..b655b8111 100644 --- a/.github/workflows/os-blas-test-matrix.yml +++ b/.github/workflows/os-blas-test-matrix.yml @@ -43,11 +43,11 @@ jobs: steps: - name: Set up Python - uses: actions/setup-python@v4 + uses: actions/setup-python@v7 with: python-version: ${{ matrix.python }} - name: Checkout Slycot - uses: actions/checkout@v3 + uses: actions/checkout@v7 with: repository: python-control/Slycot fetch-depth: 0 @@ -113,7 +113,7 @@ jobs: steps: - name: Checkout Slycot - uses: actions/checkout@v3 + uses: actions/checkout@v7 with: repository: python-control/Slycot fetch-depth: 0 @@ -163,7 +163,7 @@ jobs: name: slycot-wheels pattern: slycot-wheels-* - name: Checkout python-control - uses: actions/checkout@v3 + uses: actions/checkout@v7 - name: Download wheels (if any) uses: actions/download-artifact@v4 with: @@ -190,7 +190,7 @@ jobs: name: slycot-conda-pkgs pattern: slycot-conda-pkgs-* - name: Checkout python-control - uses: actions/checkout@v3 + uses: actions/checkout@v7 - name: Download conda packages uses: actions/download-artifact@v4 with: @@ -215,14 +215,14 @@ jobs: steps: - name: Checkout Slycot - uses: actions/checkout@v3 + uses: actions/checkout@v7 with: repository: 'python-control/Slycot' path: slycot-src - name: Checkout python-control - uses: actions/checkout@v3 + uses: actions/checkout@v7 - name: Setup Python - uses: actions/setup-python@v4 + uses: actions/setup-python@v7 with: python-version: ${{ matrix.python }} - name: Setup Ubuntu @@ -287,12 +287,12 @@ jobs: steps: - name: Checkout Slycot - uses: actions/checkout@v3 + uses: actions/checkout@v7 with: repository: 'python-control/Slycot' path: slycot-src - name: Checkout python-control - uses: actions/checkout@v3 + uses: actions/checkout@v7 - name: Setup macOS if: matrix.os == 'macos' run: brew install coreutils diff --git a/.github/workflows/python-package-conda.yml b/.github/workflows/python-package-conda.yml index 0aabf33bf..656e1b829 100644 --- a/.github/workflows/python-package-conda.yml +++ b/.github/workflows/python-package-conda.yml @@ -29,7 +29,7 @@ jobs: mplbackend: QtAgg steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v7 - name: Setup Conda uses: conda-incubator/setup-miniconda@v3 diff --git a/.github/workflows/ruff-check.yml b/.github/workflows/ruff-check.yml index e056204bf..cd1536c83 100644 --- a/.github/workflows/ruff-check.yml +++ b/.github/workflows/ruff-check.yml @@ -12,10 +12,10 @@ jobs: steps: - name: Checkout python-control - uses: actions/checkout@v3 + uses: actions/checkout@v7 - name: Setup environment - uses: actions/setup-python@v4 + uses: actions/setup-python@v7 with: python-version: 3.13 # todo: latest? From 4eac573288227db92a5f7298bf3e0444d41820c1 Mon Sep 17 00:00:00 2001 From: "Scott C. Livingston" Date: Wed, 28 Oct 2026 22:10:45 -0700 Subject: [PATCH 3/3] CI: update Slycot build given upstream changes Reference is .github/workflows/conda-build.yml in the Slycot repository, https://github.com/python-control/Slycot/blob/9613af6364334cc1f42cc7e742383aac2a5ae590/.github/workflows/conda-build.yml --- .github/workflows/os-blas-test-matrix.yml | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/os-blas-test-matrix.yml b/.github/workflows/os-blas-test-matrix.yml index b655b8111..6a8245cf7 100644 --- a/.github/workflows/os-blas-test-matrix.yml +++ b/.github/workflows/os-blas-test-matrix.yml @@ -119,23 +119,21 @@ jobs: fetch-depth: 0 submodules: 'recursive' - name: Setup Conda - uses: conda-incubator/setup-miniconda@v3 + uses: conda-incubator/setup-miniconda@v4 with: - python-version: ${{ matrix.python }} + auto-update-conda: true activate-environment: build-env - environment-file: .github/conda-env/build-env.yml miniforge-version: latest - channels: conda-forge,defaults + conda-build-version: 26.3.0 channel-priority: strict - auto-update-conda: false - auto-activate-base: false - name: Conda build shell: bash -el {0} run: | set -e - conda mambabuild conda-recipe + conda install conda-index + conda build conda-recipe --python ${{ matrix.python }} # preserve directory structure for custom conda channel - find "${CONDA_PREFIX}/conda-bld" -maxdepth 2 -name 'slycot*.tar.bz2' | while read -r conda_pkg; do + find "${CONDA_PREFIX}" -maxdepth 2 -name 'slycot*.tar.bz2' | while read -r conda_pkg; do conda_platform=$(basename $(dirname "${conda_pkg}")) mkdir -p "slycot-conda-pkgs/${conda_platform}" cp "${conda_pkg}" "slycot-conda-pkgs/${conda_platform}/"