You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
model_reduction does not preserve the sampling time (dt) of discrete-time systems #1277
model_reduction appears to lose the timebase of a discrete-time state-space system.
In python-control, dt=0 denotes a continuous-time system, while a nonzero dt denotes a discrete-time system. When reducing a discrete-time system, the returned model currently appears to be constructed without preserving the original system's dt.
Observed output (from the reporter's environment):
0.1 0 False
Expected output:
0.1 0.1 True
The reduced model should preserve the original system's timebase.
Possible cause
The reduced state-space model may be constructed as StateSpace(Ar, Br, Cr, Dr) without passing sys.dt, causing it to default to continuous time. Passing the original timebase when constructing the reduced model may address the issue.
Environment
The reporter's test environment:
python-control: source commit bfe9380e
Python: 3.12.14
NumPy: 2.5.5
SciPy: 1.18.1
Related discussion: PR #1276, where opening an issue was requested to clarify the intended behavior.
Activity