Skip to content
This repository was archived by the owner on Apr 15, 2024. It is now read-only.

fix txn token,dc and consistency#225

Open
amuhametov wants to merge 17 commits into
python-consul:masterfrom
amuhametov:txn_fix_148
Open

fix txn token,dc and consistency#225
amuhametov wants to merge 17 commits into
python-consul:masterfrom
amuhametov:txn_fix_148

Conversation

@amuhametov

@amuhametov amuhametov commented Aug 2, 2018

Copy link
Copy Markdown

fixes #148

@amuhametov

amuhametov commented Aug 3, 2018

Copy link
Copy Markdown
Author

added auto-decode for values

@matusvalo

matusvalo commented Aug 14, 2018

Copy link
Copy Markdown
Collaborator

Hi @amuhametov, Thank you for your PR! I will review your PR soon. Stay tuned!

matusvalo
matusvalo reviewed Aug 27, 2018
View reviewed changes
Comment thread consul/base.py
is_id=False,
index=False):
index=False,
txn=False):

@matusvalo matusvalo Aug 27, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add new parameters to docs string?

@amuhametov amuhametov Oct 8, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

matusvalo
matusvalo reviewed Aug 27, 2018
View reviewed changes
Comment thread consul/base.py
token=None,
consistency=None,
dc=None,
decode=False):

@matusvalo matusvalo Aug 27, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this but I prefer to hide encoding/decoding logic from user. This will break API but it will be more clear. Is there any objection against it? Moreover, new parameters should be documented in doc string.

@amuhametov amuhametov Oct 8, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@matusvalo

matusvalo commented Aug 27, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@amuhametov, I have added comments to your PR. In short:

  • doc strings needs to be updated
  • I suggest to hide encoding/decoding into method logic. After this encoding and decoding are transparent to user similarly to current KV put() method logic. This can break API backward compatibility. If nobody is against I prefer to move in this direction.
  • migrate params from dict format to list format

@amuhametov

amuhametov commented Oct 8, 2018 •
edited
Loading

Copy link
Copy Markdown
Author

@matusvalo are you sure we should break the API?
I think it is wrong to annoy users. Rolled back API change.

@amuhametov

amuhametov commented Oct 23, 2018

Copy link
Copy Markdown
Author

@cablehead @matusvalo guys?

@amuhametov

amuhametov commented May 20, 2019

Copy link
Copy Markdown
Author

ping

@poppyred

poppyred commented Oct 10, 2019 •
edited
Loading

Copy link
Copy Markdown

#225 @amuhametov welcome to here

ping

@cablehead cablehead force-pushed the master branch 2 times, most recently from 636f367 to a91daae Compare April 15, 2024 01:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@matusvalo matusvalo matusvalo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

not ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for txn in HTTP API

3 participants

@amuhametov @matusvalo @poppyred