Add flag to ignore POT-Creation-Date for updates#999
Merged
akx merged 3 commits intoJul 27, 2023
Conversation
Contributor
Author
|
Ping @akx |
akx
requested changes
Jun 27, 2023
akx
left a comment
Member
There was a problem hiding this comment.
Thank you for the contribution! As mentioned inside, I think it could be more intuitive for the kwarg to be positive (and default to True).
Contributor
Author
My pleasure, thanks for taking a look! Just updated per your suggestion. |
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
=======================================
Coverage 90.90% 90.91%
=======================================
Files 25 25
Lines 4356 4358 +2
=======================================
+ Hits 3960 3962 +2
Misses 396 396
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a flag to ignore changes to POT-Creation-Date when performing updates or checks.
I use a CI check that ensures my .po files are updated before merging, but there is always a diff on POT-Creation-Date.
Related to #725 - but solving (my) problem via update instead of extract.