Skip to content

GH-87390: Add remaining tests for PEP 646 #98267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 12 commits into from
Oct 25, 2022
Merged

GH-87390: Add remaining tests for PEP 646 #98267

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
10273c6
PEP 646: Fix final TODOs in test_genericalias.py
mrahtz Oct 11, 2022
5e76ad5
PEP 646: Add tests for tuple[*Ts, T][str, *tuple[int, ...]] and similar
mrahtz Oct 11, 2022
4b51b13
PEP 646: Fix some comments in test_typing
mrahtz Oct 11, 2022
1d35bac
Merge duplicate tests with same name
mrahtz Oct 14, 2022
739ccf5
Add tests using * instead of Unpack
mrahtz Oct 14, 2022
35d1a82
Add tests for get_origin on starred/unpacked things
mrahtz Oct 14, 2022
f09cce9
Remove stray pdb.set_trace() call
gvanrossum Oct 15, 2022
af8b972
Fix get_origin test and remove debug line
mrahtz Oct 15, 2022
a48eadc
Merge branch 'main' into pep646-cleanups
mrahtz Oct 15, 2022
69caf87
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 15, 2022
67dcbfd
Move substitution tests into right test case
mrahtz Oct 16, 2022
805713c
Add test for get_args(*tuple[*Ts])
mrahtz Oct 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for get_origin on starred/unpacked things
  • Loading branch information
@mrahtz
mrahtz committed Oct 14, 2022
commit 35d1a82ae78920d64e0bf5c4ef410a8623bb39db
7 changes: 7 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5156,6 +5156,7 @@ def h(x: collections.abc.Callable[P, int]): ...
class GetUtilitiesTestCase(TestCase):
def test_get_origin(self):
T = TypeVar('T')
Ts = TypeVarTuple('Ts')
P = ParamSpec('P')
class C(Generic[T]): pass
self.assertIs(get_origin(C[int]), C)
Expand All @@ -5179,6 +5180,12 @@ class C(Generic[T]): pass
self.assertIs(get_origin(P.kwargs), P)
self.assertIs(get_origin(Required[int]), Required)
self.assertIs(get_origin(NotRequired[int]), NotRequired)
self.assertIs(get_origin((*Ts,)[0]), Unpack)
self.assertIs(get_origin(Unpack[Ts]), Unpack)
self.assertIs(get_origin((*tuple[*Ts],)[0]), tuple)
import pdb; pdb.set_trace()
Comment thread
gvanrossum marked this conversation as resolved.
Resolved
get_origin(Unpack[Tuple[Unpack[Ts]]])
self.assertIs(get_origin(Unpack[Tuple[Unpack[Ts]]]), typing.Tuple)

def test_get_args(self):
T = TypeVar('T')
Expand Down