Skip to content

bpo-46480: add typing.assert_type #30843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 9 commits into from
Mar 17, 2022
Merged

bpo-46480: add typing.assert_type #30843

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4cdf6d3
bpo-46480: add typing.assert_type
JelleZijlstra Jan 24, 2022
629f180
Merge branch 'main' into asserttype
JelleZijlstra Feb 2, 2022
3b09f1b
feedback from David Foster
JelleZijlstra Feb 2, 2022
29176e2
Merge branch 'main' into asserttype
JelleZijlstra Mar 10, 2022
e035815
Merge remote-tracking branch 'upstream/main' into asserttype
JelleZijlstra Mar 12, 2022
ba35012
Apply suggestions from code review
JelleZijlstra Mar 12, 2022
49765d3
Apply suggestions from code review
JelleZijlstra Mar 12, 2022
b2c4cc5
Update Lib/typing.py
JelleZijlstra Mar 12, 2022
e96c988
Update Doc/library/typing.rst
JelleZijlstra Mar 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feedback from David Foster
  • Loading branch information
@JelleZijlstra
JelleZijlstra committed Feb 2, 2022
commit 3b09f1b44e7c9df120b47e701c71a35979779bf6
3 changes: 2 additions & 1 deletion Doc/library/typing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1943,7 +1943,8 @@ Functions and decorators
assert_type(name, str) # ok
Comment thread
JelleZijlstra marked this conversation as resolved.
Resolved
assert_type(name, int) # type checker error

At runtime this returns the first argument unchanged.
At runtime this returns the first argument unchanged and otherwise
does nothing.
Comment thread
JelleZijlstra marked this conversation as resolved.
Resolved

Comment thread
JelleZijlstra marked this conversation as resolved.
Resolved
.. versionadded:: 3.11

Expand Down
5 changes: 3 additions & 2 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2681,8 +2681,9 @@ def test_basics(self):

def test_errors(self):
# Bogus calls are not expected to fail.
assert_type(42, 42)
assert_type(42, 'hello')
arg = 42
self.assertIs(assert_type(arg, 42), arg)
self.assertIs(assert_type(arg, 'hello'), arg)


class ForwardRefTests(BaseTestCase):
Expand Down
3 changes: 2 additions & 1 deletion Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1742,7 +1742,8 @@ def greet(name: str) -> None:
assert_type(name, str) # ok
assert_type(name, int) # type checker error

At runtime this returns the first argument unchanged.
At runtime this returns the first argument unchanged and otherwise
does nothing.

"""
return val
Expand Down