gh-150244: Fix test_create_subprocess_env_shell to handle cpython path containing spaces. #150281
Open
edvilme wants to merge 2 commits into
Open
gh-150244: Fix test_create_subprocess_env_shell to handle cpython path containing spaces. #150281edvilme wants to merge 2 commits into
test_create_subprocess_env_shell to handle cpython path containing spaces. #150281edvilme wants to merge 2 commits into
Conversation
…thon path containing spaces On non-win32 systems, the path to the executable was not quoted, causing issues when building the command if it contains spaces, causing the test to fail.
3b455ad to
8affd1e
Compare
| @@ -0,0 +1 @@ | |||
| Fix ``test_create_subprocess_env_shell`` to properly quote the executable path on both Win32 and UNIX-like systems to properly handle spaces in the path. | |||
Contributor
There was a problem hiding this comment.
news isn't needed for tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
test_create_subprocess_env_shellto properly quote the executable path on both Win32 and UNIX-like systems to properly handle spaces in the path.test.test_asyncio.test_subprocessfail if path tocpythoncontains spaces #150244