Skip to content

[security] Tools/scripts/get-remote-certificate.py is vulnerable to shell code injection #97612

New issue
New issue
Closed
Closed
[security] Tools/scripts/get-remote-certificate.py is vulnerable to shell code injection#97612
Labels
type-bugAn unexpected behavior, bug, or errortype-securityA security issue

Description

@vstinner
vstinner
opened on Sep 28, 2022

The Tools/scripts/get-remote-certificate.py script is vulnerable to shell code injection. This vulnerability was reported by Caleb Shortt (@calebshortt).

@calebshortt proposed PR #96014 to fix it.

Activity

  1. vstinner
    added
    type-bugAn unexpected behavior, bug, or error
    type-securityA security issue
    on Sep 28, 2022

  2. vstinner commented on Sep 28, 2022

    @vstinner
    vstinner
    on Sep 28, 2022
    MemberAuthor

    Example:

    $ ./python Tools/scripts/get-remote-certificate.py 'localhost"||echo 1 > /tmp/marker #:80'
(...)

$ cat /tmp/marker 
1
  3. vstinner
    changed the title [-][security][CVE-2022-37460] Tools/scripts/get-remote-certificate.py is vulnerable to shell code injection[/-] [+][security] Tools/scripts/get-remote-certificate.py is vulnerable to shell code injection[/+] on Sep 28, 2022

  4. vstinner commented on Sep 28, 2022

    @vstinner
    vstinner
    on Sep 28, 2022
    MemberAuthor

    I removed mention of CVE-2022-37460: it was withdrawn according to @gpshead.

  5. vstinner
    added a commit that references this issue on Sep 28, 2022

    gh-97612: Fix shell injection in get-remote-certificate.py (#97613)

    83a0f44
  6. miss-islington
    added 6 commits that reference this issue on Sep 28, 2022

    pythongh-97612: Fix shell injection in get-remote-certificate.py (pyt…

    0edc084

    pythongh-97612: Fix shell injection in get-remote-certificate.py (pyt…

    c61364e

    pythongh-97612: Fix shell injection in get-remote-certificate.py (pyt…

    a40a0ba

    pythongh-97612: Fix shell injection in get-remote-certificate.py (pyt…

    e00b8f2

    gh-97612: Fix shell injection in get-remote-certificate.py (GH-97613)

    94582bb

    gh-97612: Fix shell injection in get-remote-certificate.py (GH-97613)

    e3815d7

  7. vstinner commented on Sep 29, 2022

    @vstinner
    vstinner
    on Sep 29, 2022
    MemberAuthor

    I created https://discuss.python.org/t/remove-outdated-tools-scripts-scripts/19571 discussion to propose removing outdated example scripts.

  8. ambv
    added 3 commits that reference this issue on Oct 4, 2022

    [3.9] gh-97612: Fix shell injection in get-remote-certificate.py (GH-…

    d6ef680

    [3.8] gh-97612: Fix shell injection in get-remote-certificate.py (GH-…

    9062049

    [3.7] gh-97612: Fix shell injection in get-remote-certificate.py (#97613

    c7ec780
  9. vstinner
    closed this as completedon Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-bugAn unexpected behavior, bug, or errortype-securityA security issue

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions