Skip to content

Repository navigation

fix for size-fine and size-coarse output - #963

Merged
lukasoppermann merged 2 commits into
mainfrom
size-fix
May 31, 2024
Merged

fix for size-fine and size-coarse output#963
lukasoppermann merged 2 commits into
mainfrom
size-fix

Conversation

@lukasoppermann

@lukasoppermann lukasoppermann commented May 31, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@lukasoppermann
lukasoppermann requested review from a team as code owners May 31, 2024 13:02
@lukasoppermann
lukasoppermann requested a review from jonrohan May 31, 2024 13:02
@changeset-bot

changeset-bot Bot commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 57dd21c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Design Token Diff

/css/functional/size/size-coarse.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/size/size-coarse.css	2024-05-31 13:05:31.440058073 +0000
@@ -0,0 +1,7 @@
+@media (pointer: coarse) {
+  :root {
+    --control-minTarget-auto: 2.75rem;
+    --controlStack-small-gap-auto: 1rem;
+    --controlStack-medium-gap-auto: 0.75rem;
+  }
+}

/css/functional/size/size-fine.css

 
+++ /home/runner/work/primitives/primitives/dist/css/functional/size/size-fine.css	2024-05-31 13:05:31.460057955 +0000
@@ -0,0 +1,7 @@
+@media (pointer: fine) {
+  :root {
+    --control-minTarget-auto: 1rem;
+    --controlStack-small-gap-auto: 0.5rem;
+    --controlStack-medium-gap-auto: 0.5rem;
+  }
+}

/css/primitives.css

 
+++ /home/runner/work/primitives/primitives/dist/css/primitives.css	2024-05-31 13:05:31.776056087 +0000
@@ -52,8 +52,20 @@
 --breakpoint-xlarge: 80rem;
 --breakpoint-xxlarge: 87.5rem;
}
-
-
+@media (pointer: coarse) {
+  :root {
+    --control-minTarget-auto: 2.75rem;
+    --controlStack-small-gap-auto: 1rem;
+    --controlStack-medium-gap-auto: 0.75rem;
+  }
+}
+@media (pointer: fine) {
+  :root {
+    --control-minTarget-auto: 1rem;
+    --controlStack-small-gap-auto: 0.5rem;
+    --controlStack-medium-gap-auto: 0.5rem;
+  }
+}
:root {
 --control-minTarget-fine: 1rem;
 --control-minTarget-coarse: 2.75rem;

@github-actions
github-actions Bot temporarily deployed to Preview (Storybook) May 31, 2024 13:04 Inactive
@github-actions
github-actions Bot temporarily deployed to Preview (Storybook) May 31, 2024 13:06 Inactive
@lukasoppermann
lukasoppermann merged commit 8b726b8 into main May 31, 2024
@lukasoppermann
lukasoppermann deleted the size-fix branch May 31, 2024 13:10
@primer primer Bot mentioned this pull request May 30, 2024
Merged

This branch was previously deployed

2 inactive deployments
Preview (Storybook) — 57dd21c8 Deployed May 31, 2024 by github-actions[bot]
github-pages — 57dd21c8 Deployed May 31, 2024 by lukasoppermann
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan was automatically assigned from primer/css-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lukasoppermann