Skip to content

Added 2px and 6px size to base scale - #953

Merged
lukasoppermann merged 1 commit into
mainfrom
size-tokens
May 16, 2024
Merged

lukasoppermann merged 1 commit into
mainfrom
size-tokens

Conversation

@lukasoppermann

Copy link
Copy Markdown
Collaborator

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

@lukasoppermann
lukasoppermann requested review from a team as code owners May 16, 2024 07:01
@lukasoppermann
lukasoppermann requested a review from jonrohan May 16, 2024 07:01
@changeset-bot

changeset-bot Bot commented May 16, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 15ce728

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Design Token Contrast Check

light: ✅ all checks passed

Show results table for theme: light
contrastPair pass contrastRatio minimumContrastRatio
fgColor-default vs. bgColor-default ✅ 15.79:1 4.5:1
fgColor-muted vs. bgColor-default ✅ 5.33:1 4.5:1
fgColor-default vs. bgColor-muted ✅ 14.83:1 4.5:1
fgColor-muted vs. bgColor-muted ✅ 5.01:1 4.5:1
fgColor-default vs. bgColor-inset ✅ 14.83:1 4.5:1
fgColor-muted vs. bgColor-inset ✅ 5.01:1 4.5:1
fgColor-default vs. bgColor-accent-muted ✅ 13.88:1 4.5:1
fgColor-default vs. bgColor-success-muted ✅ 14.19:1 4.5:1
fgColor-default vs. bgColor-open-muted ✅ 14.19:1 4.5:1
fgColor-default vs. bgColor-danger-muted ✅ 13.77:1 4.5:1
fgColor-default vs. bgColor-closed-muted ✅ 13.77:1 4.5:1
fgColor-default vs. bgColor-attention-muted ✅ 14.65:1 4.5:1
fgColor-default vs. bgColor-severe-muted ✅ 14.26:1 4.5:1
fgColor-default vs. bgColor-done-muted ✅ 14.21:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted ✅ 14.24:1 4.5:1
fgColor-accent vs. bgColor-default ✅ 5.19:1 4.5:1
fgColor-accent vs. bgColor-muted ✅ 4.87:1 4.5:1
fgColor-accent vs. bgColor-inset ✅ 4.87:1 4.5:1
fgColor-success vs. bgColor-default ✅ 5.07:1 4.5:1
fgColor-success vs. bgColor-muted ✅ 4.77:1 4.5:1
fgColor-success vs. bgColor-inset ✅ 4.77:1 4.5:1
fgColor-open vs. bgColor-default ✅ 5.07:1 4.5:1
fgColor-open vs. bgColor-muted ✅ 4.77:1 4.5:1
fgColor-open vs. bgColor-inset ✅ 4.77:1 4.5:1
fgColor-danger vs. bgColor-default ✅ 5.24:1 4.5:1
fgColor-danger vs. bgColor-muted ✅ 4.92:1 4.5:1
fgColor-danger vs. bgColor-inset ✅ 4.92:1 4.5:1
fgColor-closed vs. bgColor-default ✅ 5.24:1 4.5:1
fgColor-closed vs. bgColor-muted ✅ 4.92:1 4.5:1
fgColor-closed vs. bgColor-inset ✅ 4.92:1 4.5:1
fgColor-attention vs. bgColor-default ✅ 4.86:1 4.5:1
fgColor-attention vs. bgColor-muted ✅ 4.57:1 4.5:1
fgColor-attention vs. bgColor-inset ✅ 4.57:1 4.5:1
fgColor-severe vs. bgColor-default ✅ 5.03:1 4.5:1
fgColor-severe vs. bgColor-muted ✅ 4.72:1 4.5:1
fgColor-severe vs. bgColor-inset ✅ 4.72:1 4.5:1
fgColor-done vs. bgColor-default ✅ 5.04:1 4.5:1
fgColor-done vs. bgColor-muted ✅ 4.73:1 4.5:1
fgColor-done vs. bgColor-inset ✅ 4.73:1 4.5:1
fgColor-sponsors vs. bgColor-default ✅ 5.04:1 4.5:1
fgColor-sponsors vs. bgColor-muted ✅ 4.73:1 4.5:1
fgColor-sponsors vs. bgColor-inset ✅ 4.73:1 4.5:1
fgColor-accent vs. bgColor-accent-muted ✅ 4.56:1 4.5:1
fgColor-success vs. bgColor-success-muted ✅ 4.56:1 4.5:1
fgColor-open vs. bgColor-open-muted ✅ 4.56:1 4.5:1
fgColor-danger vs. bgColor-danger-muted ✅ 4.57:1 4.5:1
fgColor-closed vs. bgColor-closed-muted ✅ 4.57:1 4.5:1
fgColor-attention vs. bgColor-attention-muted ✅ 4.51:1 4.5:1
fgColor-severe vs. bgColor-severe-muted ✅ 4.54:1 4.5:1
fgColor-done vs. bgColor-done-muted ✅ 4.53:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted ✅ 4.55:1 4.5:1
fgColor-onEmphasis vs. bgColor-neutral-emphasis ✅ 4.54:1 4.5:1
fgColor-onEmphasis vs. bgColor-accent-emphasis ✅ 5.19:1 4.5:1
fgColor-onEmphasis vs. bgColor-success-emphasis ✅ 4.51:1 4.5:1
fgColor-onEmphasis vs. bgColor-open-emphasis ✅ 4.51:1 4.5:1
fgColor-onEmphasis vs. bgColor-danger-emphasis ✅ 5.35:1 4.5:1
fgColor-onEmphasis vs. bgColor-closed-emphasis ✅ 5.35:1 4.5:1
fgColor-onEmphasis vs. bgColor-attention-emphasis ✅ 4.86:1 4.5:1
fgColor-onEmphasis vs. bgColor-severe-emphasis ✅ 5.03:1 4.5:1
fgColor-onEmphasis vs. bgColor-done-emphasis ✅ 5.04:1 4.5:1
fgColor-onEmphasis vs. bgColor-sponsors-emphasis ✅ 5.04:1 4.5:1
control-borderColor-emphasis vs. bgColor-default ✅ 3.27:1 3:1
control-borderColor-emphasis vs. bgColor-muted ✅ 3.08:1 3:1

dark: ✅ all checks passed

Show results table for theme: dark
contrastPair pass contrastRatio minimumContrastRatio
fgColor-default vs. bgColor-default ✅ 16.01:1 4.5:1
fgColor-muted vs. bgColor-default ✅ 6.31:1 4.5:1
fgColor-default vs. bgColor-muted ✅ 14.63:1 4.5:1
fgColor-muted vs. bgColor-muted ✅ 5.76:1 4.5:1
fgColor-default vs. bgColor-inset ✅ 17.37:1 4.5:1
fgColor-muted vs. bgColor-inset ✅ 6.84:1 4.5:1
fgColor-default vs. bgColor-accent-muted on bgColor-default ✅ 14.34:1 4.5:1
fgColor-default vs. bgColor-accent-muted on bgColor-muted ✅ 12.91:1 4.5:1
fgColor-default vs. bgColor-success-muted on bgColor-default ✅ 13.44:1 4.5:1
fgColor-default vs. bgColor-success-muted on bgColor-muted ✅ 12:1 4.5:1
fgColor-default vs. bgColor-open-muted on bgColor-default ✅ 14.28:1 4.5:1
fgColor-default vs. bgColor-open-muted on bgColor-muted ✅ 12.85:1 4.5:1
fgColor-default vs. bgColor-danger-muted on bgColor-default ✅ 14.49:1 4.5:1
fgColor-default vs. bgColor-danger-muted on bgColor-muted ✅ 13.09:1 4.5:1
fgColor-default vs. bgColor-closed-muted on bgColor-default ✅ 13.65:1 4.5:1
fgColor-default vs. bgColor-closed-muted on bgColor-muted ✅ 12.34:1 4.5:1
fgColor-default vs. bgColor-attention-muted on bgColor-default ✅ 13.4:1 4.5:1
fgColor-default vs. bgColor-attention-muted on bgColor-muted ✅ 12.08:1 4.5:1
fgColor-default vs. bgColor-severe-muted on bgColor-default ✅ 14.45:1 4.5:1
fgColor-default vs. bgColor-severe-muted on bgColor-muted ✅ 13.03:1 4.5:1
fgColor-default vs. bgColor-done-muted on bgColor-default ✅ 13.11:1 4.5:1
fgColor-default vs. bgColor-done-muted on bgColor-muted ✅ 11.71:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted on bgColor-default ✅ 14.4:1 4.5:1
fgColor-default vs. bgColor-sponsors-muted on bgColor-muted ✅ 12.98:1 4.5:1
fgColor-accent vs. bgColor-default ✅ 6.1:1 4.5:1
fgColor-accent vs. bgColor-muted ✅ 5.58:1 4.5:1
fgColor-accent vs. bgColor-inset ✅ 6.62:1 4.5:1
fgColor-success vs. bgColor-default ✅ 7.44:1 4.5:1
fgColor-success vs. bgColor-muted ✅ 6.8:1 4.5:1
fgColor-success vs. bgColor-inset ✅ 8.08:1 4.5:1
fgColor-open vs. bgColor-default ✅ 7.44:1 4.5:1
fgColor-open vs. bgColor-muted ✅ 6.8:1 4.5:1
fgColor-open vs. bgColor-inset ✅ 8.08:1 4.5:1
fgColor-danger vs. bgColor-default ✅ 5.64:1 4.5:1
fgColor-danger vs. bgColor-muted ✅ 5.16:1 4.5:1
fgColor-danger vs. bgColor-inset ✅ 6.12:1 4.5:1
fgColor-closed vs. bgColor-default ✅ 5.64:1 4.5:1
fgColor-closed vs. bgColor-muted ✅ 5.16:1 4.5:1
fgColor-closed vs. bgColor-inset ✅ 6.12:1 4.5:1
fgColor-attention vs. bgColor-default ✅ 7.49:1 4.5:1
fgColor-attention vs. bgColor-muted ✅ 6.85:1 4.5:1
fgColor-attention vs. bgColor-inset ✅ 8.13:1 4.5:1
fgColor-severe vs. bgColor-default ✅ 5.61:1 4.5:1
fgColor-severe vs. bgColor-muted ✅ 5.13:1 4.5:1
fgColor-severe vs. bgColor-inset ✅ 6.09:1 4.5:1
fgColor-done vs. bgColor-default ✅ 6.32:1 4.5:1
fgColor-done vs. bgColor-muted ✅ 5.78:1 4.5:1
fgColor-done vs. bgColor-inset ✅ 6.86:1 4.5:1
fgColor-sponsors vs. bgColor-default ✅ 5.62:1 4.5:1
fgColor-sponsors vs. bgColor-muted ✅ 5.14:1 4.5:1
fgColor-sponsors vs. bgColor-inset ✅ 6.1:1 4.5:1
fgColor-accent vs. bgColor-accent-muted on bgColor-default ✅ 5.46:1 4.5:1
fgColor-success vs. bgColor-success-muted on bgColor-default ✅ 6.25:1 4.5:1
fgColor-success vs. bgColor-success-muted on bgColor-muted ✅ 5.58:1 4.5:1
fgColor-open vs. bgColor-open-muted on bgColor-default ✅ 6.64:1 4.5:1
fgColor-open vs. bgColor-open-muted on bgColor-muted ✅ 5.97:1 4.5:1
fgColor-danger vs. bgColor-danger-muted on bgColor-default ✅ 5.1:1 4.5:1
fgColor-danger vs. bgColor-danger-muted on bgColor-muted ✅ 4.61:1 4.5:1
fgColor-closed vs. bgColor-closed-muted on bgColor-default ✅ 4.81:1 4.5:1
fgColor-attention vs. bgColor-attention-muted on bgColor-default ✅ 6.27:1 4.5:1
fgColor-attention vs. bgColor-attention-muted on bgColor-muted ✅ 5.65:1 4.5:1
fgColor-severe vs. bgColor-severe-muted on bgColor-default ✅ 5.06:1 4.5:1
fgColor-severe vs. bgColor-severe-muted on bgColor-muted ✅ 4.57:1 4.5:1
fgColor-done vs. bgColor-done-muted on bgColor-default ✅ 5.18:1 4.5:1
fgColor-done vs. bgColor-done-muted on bgColor-muted ✅ 4.62:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-default ✅ 5.06:1 4.5:1
fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-muted ✅ 4.56:1 4.5:1
fgColor-onEmphasis vs. bgColor-neutral-emphasis ✅ 4.59:1 4.5:1
fgColor-onEmphasis vs. bgColor-accent-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-success-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-open-emphasis ✅ 4.63:1 4.5:1
fgColor-onEmphasis vs. bgColor-danger-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-closed-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-attention-emphasis ✅ 4.64:1 4.5:1
fgColor-onEmphasis vs. bgColor-severe-emphasis ✅ 4.65:1 4.5:1
fgColor-onEmphasis vs. bgColor-done-emphasis ✅ 4.6:1 4.5:1
fgColor-onEmphasis vs. bgColor-sponsors-emphasis ✅ 4.57:1 4.5:1
control-borderColor-emphasis vs. bgColor-default ✅ 3.66:1 3:1
control-borderColor-emphasis vs. bgColor-muted ✅ 3.35:1 3:1

@github-actions

Copy link
Copy Markdown
Contributor

Design Token Diff

/css/base/size/size.css

+++ /home/runner/work/primitives/primitives/dist/css/base/size/size.css	2024-05-16 07:02:12.417625804 +0000
@@ -1,5 +1,7 @@
:root {
+  --base-size-2: 0.125rem;
 --base-size-4: 0.25rem;
+  --base-size-6: 0.375rem;
 --base-size-8: 0.5rem;
 --base-size-12: 0.75rem;
 --base-size-16: 1rem;

@github-actions
github-actions Bot temporarily deployed to Preview (Storybook) May 16, 2024 07:03 Inactive
@lukasoppermann
lukasoppermann merged commit 09d1380 into main May 16, 2024
@lukasoppermann
lukasoppermann deleted the size-tokens branch May 16, 2024 07:12
@primer primer Bot mentioned this pull request May 16, 2024

This branch was previously deployed

2 inactive deployments
Preview (Storybook) — 15ce7288 Deployed May 16, 2024 by github-actions[bot]
github-pages — 15ce7288 Deployed May 16, 2024 by lukasoppermann
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant