Repository navigation
converting line height to pixel value - #905
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 21f36ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Variables changedNo variables changed |
Contributor
Design Token Contrast Check
|
| contrastPair | pass | contrastRatio | minimumContrastRatio |
|---|---|---|---|
| fgColor-default vs. bgColor-default | ✅ | 15.79:1 | 4.5:1 |
| fgColor-muted vs. bgColor-default | ✅ | 5.33:1 | 4.5:1 |
| fgColor-default vs. bgColor-muted | ✅ | 14.83:1 | 4.5:1 |
| fgColor-muted vs. bgColor-muted | ✅ | 5.01:1 | 4.5:1 |
| fgColor-default vs. bgColor-inset | ✅ | 14.83:1 | 4.5:1 |
| fgColor-muted vs. bgColor-inset | ✅ | 5.01:1 | 4.5:1 |
| fgColor-default vs. bgColor-accent-muted | ✅ | 13.88:1 | 4.5:1 |
| fgColor-default vs. bgColor-success-muted | ✅ | 14.19:1 | 4.5:1 |
| fgColor-default vs. bgColor-open-muted | ✅ | 14.19:1 | 4.5:1 |
| fgColor-default vs. bgColor-danger-muted | ✅ | 13.77:1 | 4.5:1 |
| fgColor-default vs. bgColor-closed-muted | ✅ | 13.77:1 | 4.5:1 |
| fgColor-default vs. bgColor-attention-muted | ✅ | 14.65:1 | 4.5:1 |
| fgColor-default vs. bgColor-severe-muted | ✅ | 14.26:1 | 4.5:1 |
| fgColor-default vs. bgColor-done-muted | ✅ | 14.21:1 | 4.5:1 |
| fgColor-default vs. bgColor-sponsors-muted | ✅ | 14.24:1 | 4.5:1 |
| fgColor-accent vs. bgColor-default | ✅ | 5.19:1 | 4.5:1 |
| fgColor-accent vs. bgColor-muted | ✅ | 4.87:1 | 4.5:1 |
| fgColor-accent vs. bgColor-inset | ✅ | 4.87:1 | 4.5:1 |
| fgColor-success vs. bgColor-default | ✅ | 5.07:1 | 4.5:1 |
| fgColor-success vs. bgColor-muted | ✅ | 4.77:1 | 4.5:1 |
| fgColor-success vs. bgColor-inset | ✅ | 4.77:1 | 4.5:1 |
| fgColor-open vs. bgColor-default | ✅ | 5.07:1 | 4.5:1 |
| fgColor-open vs. bgColor-muted | ✅ | 4.77:1 | 4.5:1 |
| fgColor-open vs. bgColor-inset | ✅ | 4.77:1 | 4.5:1 |
| fgColor-danger vs. bgColor-default | ✅ | 5.24:1 | 4.5:1 |
| fgColor-danger vs. bgColor-muted | ✅ | 4.92:1 | 4.5:1 |
| fgColor-danger vs. bgColor-inset | ✅ | 4.92:1 | 4.5:1 |
| fgColor-closed vs. bgColor-default | ✅ | 5.24:1 | 4.5:1 |
| fgColor-closed vs. bgColor-muted | ✅ | 4.92:1 | 4.5:1 |
| fgColor-closed vs. bgColor-inset | ✅ | 4.92:1 | 4.5:1 |
| fgColor-attention vs. bgColor-default | ✅ | 4.86:1 | 4.5:1 |
| fgColor-attention vs. bgColor-muted | ✅ | 4.57:1 | 4.5:1 |
| fgColor-attention vs. bgColor-inset | ✅ | 4.57:1 | 4.5:1 |
| fgColor-severe vs. bgColor-default | ✅ | 5.03:1 | 4.5:1 |
| fgColor-severe vs. bgColor-muted | ✅ | 4.72:1 | 4.5:1 |
| fgColor-severe vs. bgColor-inset | ✅ | 4.72:1 | 4.5:1 |
| fgColor-done vs. bgColor-default | ✅ | 5.04:1 | 4.5:1 |
| fgColor-done vs. bgColor-muted | ✅ | 4.73:1 | 4.5:1 |
| fgColor-done vs. bgColor-inset | ✅ | 4.73:1 | 4.5:1 |
| fgColor-sponsors vs. bgColor-default | ✅ | 5.04:1 | 4.5:1 |
| fgColor-sponsors vs. bgColor-muted | ✅ | 4.73:1 | 4.5:1 |
| fgColor-sponsors vs. bgColor-inset | ✅ | 4.73:1 | 4.5:1 |
| fgColor-accent vs. bgColor-accent-muted | ✅ | 4.56:1 | 4.5:1 |
| fgColor-success vs. bgColor-success-muted | ✅ | 4.56:1 | 4.5:1 |
| fgColor-open vs. bgColor-open-muted | ✅ | 4.56:1 | 4.5:1 |
| fgColor-danger vs. bgColor-danger-muted | ✅ | 4.57:1 | 4.5:1 |
| fgColor-closed vs. bgColor-closed-muted | ✅ | 4.57:1 | 4.5:1 |
| fgColor-attention vs. bgColor-attention-muted | ✅ | 4.51:1 | 4.5:1 |
| fgColor-severe vs. bgColor-severe-muted | ✅ | 4.54:1 | 4.5:1 |
| fgColor-done vs. bgColor-done-muted | ✅ | 4.53:1 | 4.5:1 |
| fgColor-sponsors vs. bgColor-sponsors-muted | ✅ | 4.55:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-neutral-emphasis | ✅ | 4.54:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-accent-emphasis | ✅ | 5.19:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-success-emphasis | ✅ | 4.51:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-open-emphasis | ✅ | 4.51:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-danger-emphasis | ✅ | 5.35:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-closed-emphasis | ✅ | 5.35:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-attention-emphasis | ✅ | 4.86:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-severe-emphasis | ✅ | 5.03:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-done-emphasis | ✅ | 5.04:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-sponsors-emphasis | ✅ | 5.04:1 | 4.5:1 |
| control-borderColor-emphasis vs. bgColor-default | ✅ | 3.27:1 | 3:1 |
| control-borderColor-emphasis vs. bgColor-muted | ✅ | 3.08:1 | 3:1 |
dark: ✅ all checks passed
Show results table for theme: dark
| contrastPair | pass | contrastRatio | minimumContrastRatio |
|---|---|---|---|
| fgColor-default vs. bgColor-default | ✅ | 16.01:1 | 4.5:1 |
| fgColor-muted vs. bgColor-default | ✅ | 5.62:1 | 4.5:1 |
| fgColor-default vs. bgColor-muted | ✅ | 14.63:1 | 4.5:1 |
| fgColor-muted vs. bgColor-muted | ✅ | 5.13:1 | 4.5:1 |
| fgColor-default vs. bgColor-inset | ✅ | 17.37:1 | 4.5:1 |
| fgColor-muted vs. bgColor-inset | ✅ | 6.1:1 | 4.5:1 |
| fgColor-default vs. bgColor-accent-muted on bgColor-default | ✅ | 14.34:1 | 4.5:1 |
| fgColor-default vs. bgColor-accent-muted on bgColor-muted | ✅ | 12.91:1 | 4.5:1 |
| fgColor-default vs. bgColor-success-muted on bgColor-default | ✅ | 13.44:1 | 4.5:1 |
| fgColor-default vs. bgColor-success-muted on bgColor-muted | ✅ | 12:1 | 4.5:1 |
| fgColor-default vs. bgColor-open-muted on bgColor-default | ✅ | 14.28:1 | 4.5:1 |
| fgColor-default vs. bgColor-open-muted on bgColor-muted | ✅ | 12.85:1 | 4.5:1 |
| fgColor-default vs. bgColor-danger-muted on bgColor-default | ✅ | 14.49:1 | 4.5:1 |
| fgColor-default vs. bgColor-danger-muted on bgColor-muted | ✅ | 13.09:1 | 4.5:1 |
| fgColor-default vs. bgColor-closed-muted on bgColor-default | ✅ | 13.65:1 | 4.5:1 |
| fgColor-default vs. bgColor-closed-muted on bgColor-muted | ✅ | 12.34:1 | 4.5:1 |
| fgColor-default vs. bgColor-attention-muted on bgColor-default | ✅ | 13.4:1 | 4.5:1 |
| fgColor-default vs. bgColor-attention-muted on bgColor-muted | ✅ | 12.08:1 | 4.5:1 |
| fgColor-default vs. bgColor-severe-muted on bgColor-default | ✅ | 14.45:1 | 4.5:1 |
| fgColor-default vs. bgColor-severe-muted on bgColor-muted | ✅ | 13.03:1 | 4.5:1 |
| fgColor-default vs. bgColor-done-muted on bgColor-default | ✅ | 13.11:1 | 4.5:1 |
| fgColor-default vs. bgColor-done-muted on bgColor-muted | ✅ | 11.71:1 | 4.5:1 |
| fgColor-default vs. bgColor-sponsors-muted on bgColor-default | ✅ | 14.4:1 | 4.5:1 |
| fgColor-default vs. bgColor-sponsors-muted on bgColor-muted | ✅ | 12.98:1 | 4.5:1 |
| fgColor-accent vs. bgColor-default | ✅ | 6.1:1 | 4.5:1 |
| fgColor-accent vs. bgColor-muted | ✅ | 5.58:1 | 4.5:1 |
| fgColor-accent vs. bgColor-inset | ✅ | 6.62:1 | 4.5:1 |
| fgColor-success vs. bgColor-default | ✅ | 7.44:1 | 4.5:1 |
| fgColor-success vs. bgColor-muted | ✅ | 6.8:1 | 4.5:1 |
| fgColor-success vs. bgColor-inset | ✅ | 8.08:1 | 4.5:1 |
| fgColor-open vs. bgColor-default | ✅ | 7.44:1 | 4.5:1 |
| fgColor-open vs. bgColor-muted | ✅ | 6.8:1 | 4.5:1 |
| fgColor-open vs. bgColor-inset | ✅ | 8.08:1 | 4.5:1 |
| fgColor-danger vs. bgColor-default | ✅ | 5.64:1 | 4.5:1 |
| fgColor-danger vs. bgColor-muted | ✅ | 5.16:1 | 4.5:1 |
| fgColor-danger vs. bgColor-inset | ✅ | 6.12:1 | 4.5:1 |
| fgColor-closed vs. bgColor-default | ✅ | 5.64:1 | 4.5:1 |
| fgColor-closed vs. bgColor-muted | ✅ | 5.16:1 | 4.5:1 |
| fgColor-closed vs. bgColor-inset | ✅ | 6.12:1 | 4.5:1 |
| fgColor-attention vs. bgColor-default | ✅ | 7.49:1 | 4.5:1 |
| fgColor-attention vs. bgColor-muted | ✅ | 6.85:1 | 4.5:1 |
| fgColor-attention vs. bgColor-inset | ✅ | 8.13:1 | 4.5:1 |
| fgColor-severe vs. bgColor-default | ✅ | 5.61:1 | 4.5:1 |
| fgColor-severe vs. bgColor-muted | ✅ | 5.13:1 | 4.5:1 |
| fgColor-severe vs. bgColor-inset | ✅ | 6.09:1 | 4.5:1 |
| fgColor-done vs. bgColor-default | ✅ | 6.32:1 | 4.5:1 |
| fgColor-done vs. bgColor-muted | ✅ | 5.78:1 | 4.5:1 |
| fgColor-done vs. bgColor-inset | ✅ | 6.86:1 | 4.5:1 |
| fgColor-sponsors vs. bgColor-default | ✅ | 5.62:1 | 4.5:1 |
| fgColor-sponsors vs. bgColor-muted | ✅ | 5.14:1 | 4.5:1 |
| fgColor-sponsors vs. bgColor-inset | ✅ | 6.1:1 | 4.5:1 |
| fgColor-accent vs. bgColor-accent-muted on bgColor-default | ✅ | 5.46:1 | 4.5:1 |
| fgColor-success vs. bgColor-success-muted on bgColor-default | ✅ | 6.25:1 | 4.5:1 |
| fgColor-success vs. bgColor-success-muted on bgColor-muted | ✅ | 5.58:1 | 4.5:1 |
| fgColor-open vs. bgColor-open-muted on bgColor-default | ✅ | 6.64:1 | 4.5:1 |
| fgColor-open vs. bgColor-open-muted on bgColor-muted | ✅ | 5.97:1 | 4.5:1 |
| fgColor-danger vs. bgColor-danger-muted on bgColor-default | ✅ | 5.1:1 | 4.5:1 |
| fgColor-danger vs. bgColor-danger-muted on bgColor-muted | ✅ | 4.61:1 | 4.5:1 |
| fgColor-closed vs. bgColor-closed-muted on bgColor-default | ✅ | 4.81:1 | 4.5:1 |
| fgColor-attention vs. bgColor-attention-muted on bgColor-default | ✅ | 6.27:1 | 4.5:1 |
| fgColor-attention vs. bgColor-attention-muted on bgColor-muted | ✅ | 5.65:1 | 4.5:1 |
| fgColor-severe vs. bgColor-severe-muted on bgColor-default | ✅ | 5.06:1 | 4.5:1 |
| fgColor-severe vs. bgColor-severe-muted on bgColor-muted | ✅ | 4.57:1 | 4.5:1 |
| fgColor-done vs. bgColor-done-muted on bgColor-default | ✅ | 5.18:1 | 4.5:1 |
| fgColor-done vs. bgColor-done-muted on bgColor-muted | ✅ | 4.62:1 | 4.5:1 |
| fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-default | ✅ | 5.06:1 | 4.5:1 |
| fgColor-sponsors vs. bgColor-sponsors-muted on bgColor-muted | ✅ | 4.56:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-neutral-emphasis | ✅ | 4.59:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-accent-emphasis | ✅ | 4.63:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-success-emphasis | ✅ | 4.63:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-open-emphasis | ✅ | 4.63:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-danger-emphasis | ✅ | 4.6:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-closed-emphasis | ✅ | 4.6:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-attention-emphasis | ✅ | 4.64:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-severe-emphasis | ✅ | 4.65:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-done-emphasis | ✅ | 4.6:1 | 4.5:1 |
| fgColor-onEmphasis vs. bgColor-sponsors-emphasis | ✅ | 4.57:1 | 4.5:1 |
| control-borderColor-emphasis vs. bgColor-default | ✅ | 3.66:1 | 3:1 |
| control-borderColor-emphasis vs. bgColor-muted | ✅ | 3.35:1 | 3:1 |
lukasoppermann
force-pushed
the
figmaLineHeight
branch
from
April 19, 2024 07:57
606df5e to
49506d2
Compare
Contributor
Design Token Diff
|
lukasoppermann
temporarily deployed
to
github-pages
April 19, 2024 07:58 — with 
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
figmaLineHeight
branch
2 times, most recently
from
April 19, 2024 08:45
e408d98 to
c920fd9
Compare
lukasoppermann
temporarily deployed
to
github-pages
April 19, 2024 08:47 — with
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
figmaLineHeight
branch
from
April 19, 2024 09:29
c920fd9 to
053c100
Compare
lukasoppermann
temporarily deployed
to
github-pages
April 19, 2024 09:31 — with
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
figmaLineHeight
branch
from
April 19, 2024 11:20
053c100 to
67f6dbf
Compare
lukasoppermann
temporarily deployed
to
github-pages
April 19, 2024 11:22 — with
GitHub Actions
Inactive
lukasoppermann
force-pushed
the
figmaLineHeight
branch
from
April 19, 2024 11:34
67f6dbf to
21f36ed
Compare
lukasoppermann
temporarily deployed
to
github-pages
April 19, 2024 11:35 — with
GitHub Actions
Inactive
lukasoppermann
marked this pull request as ready for review
April 19, 2024 11:42
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
List of notable changes:
What should reviewers focus on?
Steps to test: