Skip to content

Repository navigation

Fix primary button text color - #833

Merged
langermank merged 2 commits into
mainfrom
primary-btn-fg-color
Mar 14, 2024
Merged

Fix primary button text color#833
langermank merged 2 commits into
mainfrom
primary-btn-fg-color

Conversation

@langermank

@langermank langermank commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

In the old token build, the Primary button has a hardcoded #ffffff white value. It looks too dim in dark_dimmed using scale white.

@langermank
langermank requested review from a team as code owners March 14, 2024 00:41
@langermank
langermank requested a review from jonrohan March 14, 2024 00:41
@changeset-bot

changeset-bot Bot commented Mar 14, 2024 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 221a657

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Mar 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
Variables changed 
No variables changed

@langermank langermank added the update snapshots Update visual regression test snapshots label Mar 14, 2024
@github-actions

github-actions Bot commented Mar 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Design Token Diff

/css/functional/themes/dark-dimmed.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-dimmed.css	2024-03-14 00:43:22.978059655 +0000
@@ -121,9 +121,9 @@
 --button-default-borderColor-active: #444c56;
 --button-default-borderColor-disabled: #373e47b3;
 --button-default-shadow-resting: 0px 0px 0px 0px #000000;
-  --button-primary-fgColor-rest: #cdd9e5;
+  --button-primary-fgColor-rest: #ffffff;
 --button-primary-fgColor-disabled: #cdd9e5cc;
-  --button-primary-iconColor-rest: #cdd9e5;
+  --button-primary-iconColor-rest: #ffffff;
 --button-primary-bgColor-rest: #347d39;
 --button-primary-bgColor-hover: #3b8640;
 --button-primary-bgColor-active: #428f46;
@@ -543,9 +543,9 @@
   --button-default-borderColor-active: #444c56;
   --button-default-borderColor-disabled: #373e47b3;
   --button-default-shadow-resting: 0px 0px 0px 0px #000000;
-    --button-primary-fgColor-rest: #cdd9e5;
+    --button-primary-fgColor-rest: #ffffff;
   --button-primary-fgColor-disabled: #cdd9e5cc;
-    --button-primary-iconColor-rest: #cdd9e5;
+    --button-primary-iconColor-rest: #ffffff;
   --button-primary-bgColor-rest: #347d39;
   --button-primary-bgColor-hover: #3b8640;
   --button-primary-bgColor-active: #428f46;

@github-actions
github-actions Bot temporarily deployed to storybook-preview March 14, 2024 00:44 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview March 14, 2024 00:44 Inactive
@github-actions github-actions Bot removed the update snapshots Update visual regression test snapshots label Mar 14, 2024
@langermank
langermank merged commit 3213393 into main Mar 14, 2024
@langermank
langermank deleted the primary-btn-fg-color branch March 14, 2024 14:37
@primer primer Bot mentioned this pull request Mar 14, 2024
Merged

This branch was previously deployed

2 inactive deployments
storybook-preview — 221a6577 Deployed Mar 14, 2024 by github-actions[bot]
github-pages — 221a6577 Deployed Mar 14, 2024 by langermank
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@langermank @jonrohan