Skip to content

Repository navigation

Fix danger fgColor high contrast dark - #827

Merged
langermank merged 3 commits into
mainfrom
hc-danger-button
Mar 7, 2024
Merged

Fix danger fgColor high contrast dark#827
langermank merged 3 commits into
mainfrom
hc-danger-button

Conversation

@langermank

@langermank langermank commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

Noticed this during some manual testing

dark high contrast buttons

@changeset-bot

changeset-bot Bot commented Mar 7, 2024 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c477b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Mar 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
Variables changed 
No variables changed

@langermank langermank added the update snapshots Update visual regression test snapshots label Mar 7, 2024
@github-actions

github-actions Bot commented Mar 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Design Token Diff

/css/functional/themes/dark-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-high-contrast.css	2024-03-07 01:24:56.815900622 +0000
@@ -147,7 +147,7 @@
 --button-outline-borderColor-hover: #ffffff1a;
 --button-outline-borderColor-selected: #ffffff1a;
 --button-outline-shadow-selected: 0px 0px 0px 0px #000000;
-  --button-danger-fgColor-rest: #ff8080;
+  --button-danger-fgColor-rest: #ff9492;
 --button-danger-fgColor-hover: #ffffff;
 --button-danger-fgColor-active: #ffffff;
 --button-danger-fgColor-disabled: #ff808080;
@@ -558,7 +558,7 @@
   --button-outline-borderColor-hover: #ffffff1a;
   --button-outline-borderColor-selected: #ffffff1a;
   --button-outline-shadow-selected: 0px 0px 0px 0px #000000;
-    --button-danger-fgColor-rest: #ff8080;
+    --button-danger-fgColor-rest: #ff9492;
   --button-danger-fgColor-hover: #ffffff;
   --button-danger-fgColor-active: #ffffff;
   --button-danger-fgColor-disabled: #ff808080;

@github-actions
github-actions Bot temporarily deployed to storybook-preview March 7, 2024 01:03 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview March 7, 2024 01:04 Inactive
@github-actions github-actions Bot removed the update snapshots Update visual regression test snapshots label Mar 7, 2024
@langermank
langermank marked this pull request as ready for review March 7, 2024 01:19
@langermank
langermank requested review from a team as code owners March 7, 2024 01:19
@github-actions
github-actions Bot temporarily deployed to storybook-preview March 7, 2024 01:26 Inactive
@langermank
langermank merged commit 59be710 into main Mar 7, 2024
@langermank
langermank deleted the hc-danger-button branch March 7, 2024 17:18
@primer primer Bot mentioned this pull request Mar 7, 2024
Merged

This branch was previously deployed

2 inactive deployments
storybook-preview — 3c477b7d Deployed Mar 7, 2024 by github-actions[bot]
github-pages — 3c477b7d Deployed Mar 7, 2024 by langermank
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owenniblock owenniblock owenniblock approved these changes
@lukasoppermann lukasoppermann Awaiting requested review from lukasoppermann lukasoppermann was automatically assigned from primer/css-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@langermank @owenniblock