Skip to content

Add overlay-offset var + docs - #803

Merged
langermank merged 4 commits into
mainfrom
add-overlay-offset-var
Feb 14, 2024
Merged

langermank merged 4 commits into
mainfrom
add-overlay-offset-var

Conversation

@langermank

Copy link
Copy Markdown
Contributor

Adds a size var to be used by overlays like Tooltip, ActionMenu etc that are anchored to a trigger.

@langermank
langermank requested a review from a team as a code owner February 13, 2024 18:30
@langermank
langermank requested review from a team, broccolinisoup and jonrohan February 13, 2024 18:30
@changeset-bot

changeset-bot Bot commented Feb 13, 2024 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 327e2c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Feb 13, 2024 •

Copy link
Copy Markdown
Contributor
Variables changed
No variables changed

@github-actions

github-actions Bot commented Feb 13, 2024 •

Copy link
Copy Markdown
Contributor

Design Token Diff

/css/functional/size/size.css

+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/size/size.css	2024-02-13 21:43:01.232752508 +0000
@@ -70,4 +70,5 @@
 --overlay-paddingBlock-condensed: 0.25rem;
 --overlay-paddingBlock-normal: 0.75rem;
 --overlay-borderRadius: 0.375rem;
+  --overlay-offset: 0.25rem;
}

@github-actions
github-actions Bot temporarily deployed to storybook-preview February 13, 2024 18:37 Inactive
@langermank langermank added the update snapshots Update visual regression test snapshots label Feb 13, 2024
@github-actions github-actions Bot removed the update snapshots Update visual regression test snapshots label Feb 13, 2024
@primer
primer Bot temporarily deployed to github-pages February 13, 2024 21:43 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview February 13, 2024 21:44 Inactive
@langermank
langermank merged commit fce6921 into main Feb 14, 2024
@langermank
langermank deleted the add-overlay-offset-var branch February 14, 2024 20:11
@primer primer Bot mentioned this pull request Feb 14, 2024

This branch was previously deployed

2 inactive deployments
storybook-preview — 327e2c76 Deployed Feb 13, 2024 by github-actions[bot]
github-pages — 327e2c76 Deployed Feb 13, 2024 by primer[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant