Skip to content

Repository navigation

Reduce opacity of shadow inset color - #796

Merged
langermank merged 5 commits into
mainfrom
insetShadow
Jan 24, 2024
Merged

Reduce opacity of shadow inset color#796
langermank merged 5 commits into
mainfrom
insetShadow

Conversation

@lukasoppermann

@lukasoppermann lukasoppermann commented Jan 10, 2024

Copy link
Copy Markdown
Collaborator

Summary

Reduced opacity for inset shadow to not look like a second border.

@lukasoppermann
lukasoppermann requested a review from a team as a code owner January 10, 2024 14:57
@lukasoppermann
lukasoppermann requested review from a team and langermank January 10, 2024 14:57
@changeset-bot

changeset-bot Bot commented Jan 10, 2024 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 075f92f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jan 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
Variables changed 
No variables changed

@github-actions

github-actions Bot commented Jan 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Design Token Diff

/css/functional/themes/light-colorblind.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-colorblind.css	2024-01-12 16:05:25.843754113 +0000
@@ -411,7 +411,7 @@
 --color-scale-coral-7: #801f0f;
 --color-scale-coral-8: #691105;
 --color-scale-coral-9: #510901;
-  --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+  --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
 --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
 --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
 --shadow-resting-medium: 0px 3px 6px 0px #424a531f;
@@ -832,7 +832,7 @@
   --color-scale-coral-7: #801f0f;
   --color-scale-coral-8: #691105;
   --color-scale-coral-9: #510901;
-    --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+    --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
   --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
   --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
   --shadow-resting-medium: 0px 3px 6px 0px #424a531f;

/css/functional/themes/light-high-contrast.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-high-contrast.css	2024-01-12 16:05:26.219752914 +0000
@@ -411,7 +411,7 @@
 --color-scale-coral-7: #6f0107;
 --color-scale-coral-8: #5b0002;
 --color-scale-coral-9: #430200;
-  --shadow-inset: inset 0px 1px 0px 0px #01040914;
+  --shadow-inset: inset 0px 1px 0px 0px #0104090a;
 --shadow-resting-xsmall: 0px 1px 0px 0px #0104091a;
 --shadow-resting-small: 0px 1px 0px 0px #0104090f, 0px 1px 3px 0px #01040914;
 --shadow-resting-medium: 0px 3px 6px 0px #343b431f;
@@ -832,7 +832,7 @@
   --color-scale-coral-7: #6f0107;
   --color-scale-coral-8: #5b0002;
   --color-scale-coral-9: #430200;
-    --shadow-inset: inset 0px 1px 0px 0px #01040914;
+    --shadow-inset: inset 0px 1px 0px 0px #0104090a;
   --shadow-resting-xsmall: 0px 1px 0px 0px #0104091a;
   --shadow-resting-small: 0px 1px 0px 0px #0104090f, 0px 1px 3px 0px #01040914;
   --shadow-resting-medium: 0px 3px 6px 0px #343b431f;

/css/functional/themes/light-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-tritanopia.css	2024-01-12 16:05:25.423755423 +0000
@@ -411,7 +411,7 @@
 --color-scale-coral-7: #801f0f;
 --color-scale-coral-8: #691105;
 --color-scale-coral-9: #510901;
-  --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+  --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
 --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
 --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
 --shadow-resting-medium: 0px 3px 6px 0px #424a531f;
@@ -832,7 +832,7 @@
   --color-scale-coral-7: #801f0f;
   --color-scale-coral-8: #691105;
   --color-scale-coral-9: #510901;
-    --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+    --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
   --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
   --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
   --shadow-resting-medium: 0px 3px 6px 0px #424a531f;

/css/functional/themes/light.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light.css	2024-01-12 16:05:24.955756884 +0000
@@ -411,7 +411,7 @@
 --color-scale-coral-7: #801f0f;
 --color-scale-coral-8: #691105;
 --color-scale-coral-9: #510901;
-  --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+  --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
 --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
 --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
 --shadow-resting-medium: 0px 3px 6px 0px #424a531f;
@@ -832,7 +832,7 @@
   --color-scale-coral-7: #801f0f;
   --color-scale-coral-8: #691105;
   --color-scale-coral-9: #510901;
-    --shadow-inset: inset 0px 1px 0px 0px #1f232814;
+    --shadow-inset: inset 0px 1px 0px 0px #1f23280a;
   --shadow-resting-xsmall: 0px 1px 0px 0px #1f23281a;
   --shadow-resting-small: 0px 1px 0px 0px #1f23280f, 0px 1px 3px 0px #1f232814;
   --shadow-resting-medium: 0px 3px 6px 0px #424a531f;

@github-actions
github-actions Bot temporarily deployed to storybook-preview January 10, 2024 14:59 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview January 10, 2024 16:46 Inactive
@lukasoppermann lukasoppermann added the update snapshots Update visual regression test snapshots label Jan 12, 2024
@github-actions github-actions Bot removed the update snapshots Update visual regression test snapshots label Jan 12, 2024
@joshblack joshblack added update snapshots Update visual regression test snapshots and removed update snapshots Update visual regression test snapshots labels Jan 12, 2024
@joshblack joshblack added the update snapshots Update visual regression test snapshots label Jan 12, 2024
@github-actions
github-actions Bot temporarily deployed to storybook-preview January 12, 2024 15:57 Inactive
@github-actions github-actions Bot removed the update snapshots Update visual regression test snapshots label Jan 12, 2024
@primer
primer Bot temporarily deployed to github-pages January 12, 2024 16:06 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview January 12, 2024 16:06 Inactive
@langermank
langermank merged commit d842f87 into main Jan 24, 2024
@langermank
langermank deleted the insetShadow branch January 24, 2024 16:32
@primer primer Bot mentioned this pull request Jan 12, 2024
Merged

This branch was previously deployed

2 inactive deployments
storybook-preview — 075f92f8 Deployed Jan 12, 2024 by github-actions[bot]
github-pages — 075f92f8 Deployed Jan 12, 2024 by primer[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@langermank langermank langermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukasoppermann @langermank @joshblack