Skip to content

Repository navigation

breakpoint was using wrong value - #783

Merged
lukasoppermann merged 3 commits into
mainfrom
fix-breakpoint
Nov 22, 2023
Merged

breakpoint was using wrong value#783
lukasoppermann merged 3 commits into
mainfrom
fix-breakpoint

Conversation

@lukasoppermann

@lukasoppermann lukasoppermann commented Nov 22, 2023

Copy link
Copy Markdown
Collaborator

Summary

Fix xxlarge breakpoint value

@lukasoppermann
lukasoppermann requested a review from a team as a code owner November 22, 2023 16:22
@lukasoppermann
lukasoppermann requested review from a team, langermank and tobiasahlin November 22, 2023 16:22
@changeset-bot

changeset-bot Bot commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6e9909c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
Variables changed 
No variables changed

@github-actions

github-actions Bot commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Design Token Diff

/css/functional/size/breakpoints.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/size/breakpoints.css	2023-11-22 16:46:31.497619976 +0000
@@ -4,5 +4,5 @@
 --breakpoint-medium: 48rem;
 --breakpoint-large: 63.25rem;
 --breakpoint-xlarge: 80rem;
-  --breakpoint-xxlarge: 90rem;
+  --breakpoint-xxlarge: 87.5rem;
}

/css/functional/size/viewport.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/size/viewport.css	2023-11-22 16:46:31.613620022 +0000
@@ -1,6 +1,6 @@
@custom-media --viewportRange-narrow (max-width: calc(48rem - 0.02px));
@custom-media --viewportRange-narrowLandscape (max-width: calc(63.25rem - 0.02px) and (max-height: calc(34rem - 0.02px)) and (orientation: landscape));
@custom-media --viewportRange-regular (min-width: 48rem);
-@custom-media --viewportRange-wide (min-width: 90rem);
+@custom-media --viewportRange-wide (min-width: 87.5rem);
@custom-media --viewportRange-portrait (orientation: portrait);
@custom-media --viewportRange-landscape (orientation: landscape);

@github-actions
github-actions Bot temporarily deployed to storybook-preview November 22, 2023 16:24 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview November 22, 2023 16:26 Inactive
@lukasoppermann lukasoppermann added the update snapshots Update visual regression test snapshots label Nov 22, 2023
@github-actions github-actions Bot removed the update snapshots Update visual regression test snapshots label Nov 22, 2023
@github-actions
github-actions Bot temporarily deployed to storybook-preview November 22, 2023 16:47 Inactive
@lukasoppermann
lukasoppermann merged commit d0f95c7 into main Nov 22, 2023
@lukasoppermann
lukasoppermann deleted the fix-breakpoint branch November 22, 2023 16:58
@primer primer Bot mentioned this pull request Nov 22, 2023
Merged

This branch was previously deployed

2 inactive deployments
storybook-preview — 6e9909c0 Deployed Nov 22, 2023 by github-actions[bot]
github-pages — 6e9909c0 Deployed Nov 22, 2023 by lukasoppermann
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasahlin tobiasahlin Awaiting requested review from tobiasahlin tobiasahlin was automatically assigned from primer/css-reviewers
1 more reviewer
@langermank langermank langermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukasoppermann @langermank