Skip to content

Repository navigation

remove alpha override - #742

Merged
lukasoppermann merged 3 commits into
mainfrom
botfixButtonCounterAlpha
Sep 27, 2023
Merged

remove alpha override#742
lukasoppermann merged 3 commits into
mainfrom
botfixButtonCounterAlpha

Conversation

@lukasoppermann

@lukasoppermann lukasoppermann commented Sep 27, 2023

Copy link
Copy Markdown
Collaborator

Summary

This fixes a bug with the color for button counters being to dark

@lukasoppermann lukasoppermann added the update snapshots Update visual regression test snapshots label Sep 27, 2023
@lukasoppermann
lukasoppermann requested a review from a team as a code owner September 27, 2023 07:04
@lukasoppermann
lukasoppermann requested review from a team, jonrohan and mperrotti September 27, 2023 07:04
@changeset-bot

changeset-bot Bot commented Sep 27, 2023 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 436b090

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Sep 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
Variables changed 
No variables changed

@github-actions

github-actions Bot commented Sep 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Design Token Diff

/css/functional/themes/light-colorblind.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-colorblind.css	2023-09-27 07:07:00.558740840 +0000
@@ -159,8 +159,8 @@
 --button-danger-borderColor-hover: #1f232826;
 --button-danger-borderColor-active: #1f232826;
 --button-danger-shadow-selected: inset 0px 1px 0px 0px #47170033;
-  --buttonCounter-default-bgColor-rest: #afb8c1;
-  --buttonCounter-invisible-bgColor-rest: #afb8c1;
+  --buttonCounter-default-bgColor-rest: #afb8c133;
+  --buttonCounter-invisible-bgColor-rest: #afb8c133;
 --buttonCounter-primary-bgColor-rest: #002d1133;
 --buttonCounter-outline-bgColor-rest: #0969da1a;
 --buttonCounter-outline-bgColor-hover: #ffffff33;
@@ -576,8 +576,8 @@
   --button-danger-borderColor-hover: #1f232826;
   --button-danger-borderColor-active: #1f232826;
   --button-danger-shadow-selected: inset 0px 1px 0px 0px #47170033;
-    --buttonCounter-default-bgColor-rest: #afb8c1;
-    --buttonCounter-invisible-bgColor-rest: #afb8c1;
+    --buttonCounter-default-bgColor-rest: #afb8c133;
+    --buttonCounter-invisible-bgColor-rest: #afb8c133;
   --buttonCounter-primary-bgColor-rest: #002d1133;
   --buttonCounter-outline-bgColor-rest: #0969da1a;
   --buttonCounter-outline-bgColor-hover: #ffffff33;

/css/functional/themes/light-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-tritanopia.css	2023-09-27 07:07:00.018726722 +0000
@@ -159,8 +159,8 @@
 --button-danger-borderColor-hover: #1f232826;
 --button-danger-borderColor-active: #1f232826;
 --button-danger-shadow-selected: inset 0px 1px 0px 0px #4c001433;
-  --buttonCounter-default-bgColor-rest: #afb8c1;
-  --buttonCounter-invisible-bgColor-rest: #afb8c1;
+  --buttonCounter-default-bgColor-rest: #afb8c133;
+  --buttonCounter-invisible-bgColor-rest: #afb8c133;
 --buttonCounter-primary-bgColor-rest: #002d1133;
 --buttonCounter-outline-bgColor-rest: #0969da1a;
 --buttonCounter-outline-bgColor-hover: #ffffff33;
@@ -576,8 +576,8 @@
   --button-danger-borderColor-hover: #1f232826;
   --button-danger-borderColor-active: #1f232826;
   --button-danger-shadow-selected: inset 0px 1px 0px 0px #4c001433;
-    --buttonCounter-default-bgColor-rest: #afb8c1;
-    --buttonCounter-invisible-bgColor-rest: #afb8c1;
+    --buttonCounter-default-bgColor-rest: #afb8c133;
+    --buttonCounter-invisible-bgColor-rest: #afb8c133;
   --buttonCounter-primary-bgColor-rest: #002d1133;
   --buttonCounter-outline-bgColor-rest: #0969da1a;
   --buttonCounter-outline-bgColor-hover: #ffffff33;

/css/functional/themes/light.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light.css	2023-09-27 07:06:59.414710932 +0000
@@ -159,8 +159,8 @@
 --button-danger-borderColor-hover: #1f232826;
 --button-danger-borderColor-active: #1f232826;
 --button-danger-shadow-selected: inset 0px 1px 0px 0px #4c001433;
-  --buttonCounter-default-bgColor-rest: #afb8c1;
-  --buttonCounter-invisible-bgColor-rest: #afb8c1;
+  --buttonCounter-default-bgColor-rest: #afb8c133;
+  --buttonCounter-invisible-bgColor-rest: #afb8c133;
 --buttonCounter-primary-bgColor-rest: #002d1133;
 --buttonCounter-outline-bgColor-rest: #0969da1a;
 --buttonCounter-outline-bgColor-hover: #ffffff33;
@@ -576,8 +576,8 @@
   --button-danger-borderColor-hover: #1f232826;
   --button-danger-borderColor-active: #1f232826;
   --button-danger-shadow-selected: inset 0px 1px 0px 0px #4c001433;
-    --buttonCounter-default-bgColor-rest: #afb8c1;
-    --buttonCounter-invisible-bgColor-rest: #afb8c1;
+    --buttonCounter-default-bgColor-rest: #afb8c133;
+    --buttonCounter-invisible-bgColor-rest: #afb8c133;
   --buttonCounter-primary-bgColor-rest: #002d1133;
   --buttonCounter-outline-bgColor-rest: #0969da1a;
   --buttonCounter-outline-bgColor-hover: #ffffff33;

@github-actions
github-actions Bot temporarily deployed to storybook-preview September 27, 2023 07:08 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview September 27, 2023 07:09 Inactive
@lukasoppermann lukasoppermann added update snapshots Update visual regression test snapshots and removed update snapshots Update visual regression test snapshots labels Sep 27, 2023
@github-actions github-actions Bot removed the update snapshots Update visual regression test snapshots label Sep 27, 2023
@lukasoppermann
lukasoppermann merged commit efa8b1c into main Sep 27, 2023
@lukasoppermann
lukasoppermann deleted the botfixButtonCounterAlpha branch September 27, 2023 07:24
@primer primer Bot mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan was automatically assigned from primer/css-reviewers
@mperrotti mperrotti Awaiting requested review from mperrotti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lukasoppermann