Repository navigation
Add icon color for invisible button - #734
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c905cf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Variables changedNo variables changed |
Contributor
Design Token Diff
|
| }, | ||
| }, | ||
| hover: { | ||
| $value: '{fgColor.muted}', |
Collaborator
There was a problem hiding this comment.
In dark mode this is using fgColor.default shouldn't it be the same in both modes?
Contributor
Author
There was a problem hiding this comment.
Spoke offline- it looks pretty harsh in light mode and isn't required to pass contrast, so I'm only changing the color in dark mode. I think it feels more expected to see a lighter effect in a dark theme on hover vs. darker in light mode.
langermank
temporarily deployed
to
github-pages
September 20, 2023 14:37 — with
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
September 20, 2023 20:03 — with
GitHub Actions
Inactive
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iconColortokens for theinvisiblebutton variant