Skip to content

Format fallback CSS vars with var() - #651

Merged
langermank merged 2 commits into
mainfrom
fallback-css-var
May 10, 2023
Merged

langermank merged 2 commits into
mainfrom
fallback-css-var

Conversation

@langermank

Copy link
Copy Markdown
Contributor
  • Add var(--) for JSON
  • Remove var(--) for Storybook

@langermank
langermank requested a review from a team as a code owner May 10, 2023 21:24
@langermank
langermank requested review from a team, jonrohan and joshblack May 10, 2023 21:24
@changeset-bot

changeset-bot Bot commented May 10, 2023 •

Copy link
Copy Markdown

πŸ¦‹ Changeset detected

Latest commit: 2df5086

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented May 10, 2023 •

Copy link
Copy Markdown
Contributor
Variables changed
No variables changed

@github-actions

Copy link
Copy Markdown
Contributor

Design Token Diff

No design tokens changed

@jonrohan jonrohan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸ»

@langermank
langermank merged commit 26ed1fc into main May 10, 2023
@langermank
langermank deleted the fallback-css-var branch May 10, 2023 21:30
@primer-css primer-css mentioned this pull request May 10, 2023
langermank added a commit that referenced this pull request Jun 1, 2023
* please work

* Create three-peaches-travel.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants