Skip to content

Repository navigation

Add missing color overrides for dark tritanopia in v8 tokens - #645

Merged
lukasoppermann merged 1 commit into
mainfrom
colorblind-fix-dark-tritanopia
May 9, 2023
Merged

Add missing color overrides for dark tritanopia in v8 tokens#645
lukasoppermann merged 1 commit into
mainfrom
colorblind-fix-dark-tritanopia

Conversation

@lukasoppermann

@lukasoppermann lukasoppermann commented May 9, 2023

Copy link
Copy Markdown
Collaborator

Summary

Add missing color overrides for dark tritanopia in v8 tokens

@lukasoppermann
lukasoppermann requested a review from a team as a code owner May 9, 2023 09:45
@lukasoppermann
lukasoppermann requested review from a team, rezrah and siddharthkp May 9, 2023 09:45
@changeset-bot

changeset-bot Bot commented May 9, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8f7feaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented May 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
Variables changed 
No variables changed

@github-actions

github-actions Bot commented May 9, 2023

Copy link
Copy Markdown
Contributor

Design Token Diff

/css/functional/themes/dark-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-tritanopia.css	2023-05-09 09:46:24.667305912 +0000
@@ -212,10 +212,10 @@
 --bgColor-severe-emphasis: #da3633;
 --bgColor-danger-muted: #f851491a;
 --bgColor-danger-emphasis: #da3633;
-  --bgColor-open-muted: #388bfd1a;
-  --bgColor-open-emphasis: #1f6feb;
-  --bgColor-closed-muted: #f8514926;
-  --bgColor-closed-emphasis: #da3633;
+  --bgColor-open-muted: #f851491a;
+  --bgColor-open-emphasis: #da3633;
+  --bgColor-closed-muted: #6e768126;
+  --bgColor-closed-emphasis: #484f58;
 --bgColor-done-muted: #a371f726;
 --bgColor-done-emphasis: #8957e5;
 --bgColor-sponsors-muted: #db61a21a;
@@ -236,10 +236,10 @@
 --borderColor-severe-emphasis: #da3633;
 --borderColor-danger-muted: #f8514966;
 --borderColor-danger-emphasis: #da3633;
-  --borderColor-open-muted: #388bfd66;
-  --borderColor-open-emphasis: #1f6feb;
-  --borderColor-closed-muted: #f8514966;
-  --borderColor-closed-emphasis: #da3633;
+  --borderColor-open-muted: #f8514966;
+  --borderColor-open-emphasis: #da3633;
+  --borderColor-closed-muted: #6e768166;
+  --borderColor-closed-emphasis: #484f58;
 --borderColor-done-muted: #a371f766;
 --borderColor-done-emphasis: #8957e5;
 --borderColor-sponsors-muted: #db61a266;
@@ -609,10 +609,10 @@
   --bgColor-severe-emphasis: #da3633;
   --bgColor-danger-muted: #f851491a;
   --bgColor-danger-emphasis: #da3633;
-    --bgColor-open-muted: #388bfd1a;
-    --bgColor-open-emphasis: #1f6feb;
-    --bgColor-closed-muted: #f8514926;
-    --bgColor-closed-emphasis: #da3633;
+    --bgColor-open-muted: #f851491a;
+    --bgColor-open-emphasis: #da3633;
+    --bgColor-closed-muted: #6e768126;
+    --bgColor-closed-emphasis: #484f58;
   --bgColor-done-muted: #a371f726;
   --bgColor-done-emphasis: #8957e5;
   --bgColor-sponsors-muted: #db61a21a;
@@ -633,10 +633,10 @@
   --borderColor-severe-emphasis: #da3633;
   --borderColor-danger-muted: #f8514966;
   --borderColor-danger-emphasis: #da3633;
-    --borderColor-open-muted: #388bfd66;
-    --borderColor-open-emphasis: #1f6feb;
-    --borderColor-closed-muted: #f8514966;
-    --borderColor-closed-emphasis: #da3633;
+    --borderColor-open-muted: #f8514966;
+    --borderColor-open-emphasis: #da3633;
+    --borderColor-closed-muted: #6e768166;
+    --borderColor-closed-emphasis: #484f58;
   --borderColor-done-muted: #a371f766;
   --borderColor-done-emphasis: #8957e5;
   --borderColor-sponsors-muted: #db61a266;

/css/functional/themes/light-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-tritanopia.css	2023-05-09 09:46:21.087152336 +0000
@@ -215,14 +215,12 @@
 --bgColor-danger-emphasis: #cf222e;
 --bgColor-open-muted: #ffebe9;
 --bgColor-open-emphasis: #cf222e;
-  --bgColor-closed-muted: #ffebe9;
-  --bgColor-closed-emphasis: #cf222e;
+  --bgColor-closed-muted: #f6f8fa;
+  --bgColor-closed-emphasis: #6e7781;
 --bgColor-done-muted: #fbefff;
 --bgColor-done-emphasis: #8250df;
 --bgColor-sponsors-muted: #ffeff7;
 --bgColor-sponsors-emphasis: #bf3989;
-  --bgColor-gray-muted: #f6f8fa;
-  --bgColor-gray-emphasis: #6e7781;
 --borderColor-default: #d0d7de;
 --borderColor-muted: #d0d7de66;
 --borderColor-emphasis: #6e7781;
@@ -614,14 +612,12 @@
   --bgColor-danger-emphasis: #cf222e;
   --bgColor-open-muted: #ffebe9;
   --bgColor-open-emphasis: #cf222e;
-    --bgColor-closed-muted: #ffebe9;
-    --bgColor-closed-emphasis: #cf222e;
+    --bgColor-closed-muted: #f6f8fa;
+    --bgColor-closed-emphasis: #6e7781;
   --bgColor-done-muted: #fbefff;
   --bgColor-done-emphasis: #8250df;
   --bgColor-sponsors-muted: #ffeff7;
   --bgColor-sponsors-emphasis: #bf3989;
-    --bgColor-gray-muted: #f6f8fa;
-    --bgColor-gray-emphasis: #6e7781;
   --borderColor-default: #d0d7de;
   --borderColor-muted: #d0d7de66;
   --borderColor-emphasis: #6e7781;

@github-actions
github-actions Bot temporarily deployed to storybook-preview May 9, 2023 09:51 Inactive
@lukasoppermann
lukasoppermann merged commit 40880ce into main May 9, 2023
@lukasoppermann
lukasoppermann deleted the colorblind-fix-dark-tritanopia branch May 9, 2023 09:54
@primer-css primer-css mentioned this pull request May 9, 2023
Merged
langermank pushed a commit that referenced this pull request Jun 1, 2023
@lukasoppermann @langermank
add fixes (#645)
33d86de

This branch was previously deployed

2 inactive deployments
storybook-preview — 8f7feaf0 Deployed May 9, 2023 by github-actions[bot]
github-pages — 8f7feaf0 Deployed May 9, 2023 by lukasoppermann
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lukasoppermann