Skip to content

Repository navigation

updating default and muted text in dark mode - #516

Merged
lukasoppermann merged 1 commit into
mainfrom
a11y/darkmode-text
Mar 29, 2023
Merged

updating default and muted text in dark mode#516
lukasoppermann merged 1 commit into
mainfrom
a11y/darkmode-text

Conversation

@lukasoppermann

@lukasoppermann lukasoppermann commented Mar 14, 2023

Copy link
Copy Markdown
Collaborator

Summary

This PR fixes the failing contrast between the default text and muted in dark mode as part of https://github.com/github/primer/issues/1648.

It addresses both the current (old) implementation as well as the new v3 tokens.

@lukasoppermann
lukasoppermann requested a review from a team as a code owner March 14, 2023 16:11
@lukasoppermann lukasoppermann self-assigned this Mar 14, 2023
@lukasoppermann
lukasoppermann requested a review from a team March 14, 2023 16:12
@changeset-bot

changeset-bot Bot commented Mar 14, 2023 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 34b4898

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Mar 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
Variables changed 
--- base/dist/scss/colors/_dark.scss	2023-03-29 07:17:43.021778568 +0000
+++ dist/scss/colors/_dark.scss	2023-03-29 07:16:26.777757072 +0000
@@ -6,4 +6,4 @@
     --color-marketing-icon-secondary: #1f6feb;
-    --color-diff-blob-addition-num-text: #c9d1d9;
-    --color-diff-blob-addition-fg: #c9d1d9;
+    --color-diff-blob-addition-num-text: #e6edf3;
+    --color-diff-blob-addition-fg: #e6edf3;
     --color-diff-blob-addition-num-bg: rgba(63,185,80,0.3);
@@ -11,4 +11,4 @@
     --color-diff-blob-addition-word-bg: rgba(46,160,67,0.4);
-    --color-diff-blob-deletion-num-text: #c9d1d9;
-    --color-diff-blob-deletion-fg: #c9d1d9;
+    --color-diff-blob-deletion-num-text: #e6edf3;
+    --color-diff-blob-deletion-fg: #e6edf3;
     --color-diff-blob-deletion-num-bg: rgba(248,81,73,0.3);
@@ -17,3 +17,3 @@
     --color-diff-blob-hunk-num-bg: rgba(56,139,253,0.4);
-    --color-diff-blob-expander-icon: #8b949e;
+    --color-diff-blob-expander-icon: #7d8590;
     --color-diff-blob-selected-line-highlight-mix-blend-mode: screen;
@@ -53,3 +53,3 @@
     --color-prettylights-syntax-constant-other-reference-link: #a5d6ff;
-    --color-codemirror-text: #c9d1d9;
+    --color-codemirror-text: #e6edf3;
     --color-codemirror-bg: #0d1117;
@@ -58,7 +58,7 @@
     --color-codemirror-guttermarker-subtle-text: #6e7681;
-    --color-codemirror-linenumber-text: #8b949e;
-    --color-codemirror-cursor: #c9d1d9;
+    --color-codemirror-linenumber-text: #7d8590;
+    --color-codemirror-cursor: #e6edf3;
     --color-codemirror-selection-bg: rgba(56,139,253,0.4);
     --color-codemirror-activeline-bg: rgba(110,118,129,0.1);
-    --color-codemirror-matchingbracket-text: #c9d1d9;
+    --color-codemirror-matchingbracket-text: #e6edf3;
     --color-codemirror-lines-bg: #0d1117;
@@ -75,11 +75,11 @@
     --color-checks-container-border-width: 1px;
-    --color-checks-text-primary: #c9d1d9;
-    --color-checks-text-secondary: #8b949e;
+    --color-checks-text-primary: #e6edf3;
+    --color-checks-text-secondary: #7d8590;
     --color-checks-text-link: #58a6ff;
-    --color-checks-btn-icon: #8b949e;
-    --color-checks-btn-hover-icon: #c9d1d9;
+    --color-checks-btn-icon: #7d8590;
+    --color-checks-btn-hover-icon: #e6edf3;
     --color-checks-btn-hover-bg: rgba(110,118,129,0.1);
-    --color-checks-input-text: #8b949e;
+    --color-checks-input-text: #7d8590;
     --color-checks-input-placeholder-text: #6e7681;
-    --color-checks-input-focus-text: #c9d1d9;
+    --color-checks-input-focus-text: #e6edf3;
     --color-checks-input-bg: #161b22;
@@ -90,3 +90,3 @@
     --color-checks-donut-neutral: #8b949e;
-    --color-checks-dropdown-text: #c9d1d9;
+    --color-checks-dropdown-text: #e6edf3;
     --color-checks-dropdown-bg: #161b22;
@@ -94,12 +94,12 @@
     --color-checks-dropdown-shadow: rgba(1,4,9,0.3);
-    --color-checks-dropdown-hover-text: #c9d1d9;
+    --color-checks-dropdown-hover-text: #e6edf3;
     --color-checks-dropdown-hover-bg: rgba(110,118,129,0.1);
-    --color-checks-dropdown-btn-hover-text: #c9d1d9;
+    --color-checks-dropdown-btn-hover-text: #e6edf3;
     --color-checks-dropdown-btn-hover-bg: rgba(110,118,129,0.1);
     --color-checks-scrollbar-thumb-bg: rgba(110,118,129,0.4);
-    --color-checks-header-label-text: #8b949e;
-    --color-checks-header-label-open-text: #c9d1d9;
+    --color-checks-header-label-text: #7d8590;
+    --color-checks-header-label-open-text: #e6edf3;
     --color-checks-header-border: #21262d;
-    --color-checks-header-icon: #8b949e;
-    --color-checks-line-text: #8b949e;
+    --color-checks-header-icon: #7d8590;
+    --color-checks-line-text: #7d8590;
     --color-checks-line-num-text: #6e7681;
@@ -112,3 +112,3 @@
     --color-checks-gate-bg: rgba(187,128,9,0.15);
-    --color-checks-gate-text: #8b949e;
+    --color-checks-gate-text: #7d8590;
     --color-checks-gate-waiting-text: #d29922;
@@ -117,9 +117,9 @@
     --color-checks-step-warning-text: #d29922;
-    --color-checks-logline-text: #8b949e;
+    --color-checks-logline-text: #7d8590;
     --color-checks-logline-num-text: #6e7681;
     --color-checks-logline-debug-text: #a371f7;
-    --color-checks-logline-error-text: #8b949e;
+    --color-checks-logline-error-text: #7d8590;
     --color-checks-logline-error-num-text: #6e7681;
     --color-checks-logline-error-bg: rgba(248,81,73,0.15);
-    --color-checks-logline-warning-text: #8b949e;
+    --color-checks-logline-warning-text: #7d8590;
     --color-checks-logline-warning-num-text: #d29922;
@@ -265,3 +265,3 @@
     --color-switch-track-disabled-bg: #21262d;
-    --color-switch-track-fg: #8b949e;
+    --color-switch-track-fg: #7d8590;
     --color-switch-track-disabled-fg: #010409;
@@ -286,5 +286,5 @@
     --color-tree-view-item-chevron-hover-bg: rgba(177,186,196,0.12);
-    --color-tree-view-item-directory-fill: #8b949e;
-    --color-fg-default: #c9d1d9;
-    --color-fg-muted: #8b949e;
+    --color-tree-view-item-directory-fill: #7d8590;
+    --color-fg-default: #e6edf3;
+    --color-fg-muted: #7d8590;
     --color-fg-subtle: #6e7681;
--- base/dist/scss/colors/_dark_colorblind.scss	2023-03-29 07:17:43.037779419 +0000
+++ dist/scss/colors/_dark_colorblind.scss	2023-03-29 07:16:26.801758408 +0000
@@ -6,4 +6,4 @@
     --color-marketing-icon-secondary: #1f6feb;
-    --color-diff-blob-addition-num-text: #c9d1d9;
-    --color-diff-blob-addition-fg: #c9d1d9;
+    --color-diff-blob-addition-num-text: #e6edf3;
+    --color-diff-blob-addition-fg: #e6edf3;
     --color-diff-blob-addition-num-bg: rgba(88,166,255,0.3);
@@ -11,4 +11,4 @@
     --color-diff-blob-addition-word-bg: rgba(56,139,253,0.4);
-    --color-diff-blob-deletion-num-text: #c9d1d9;
-    --color-diff-blob-deletion-fg: #c9d1d9;
+    --color-diff-blob-deletion-num-text: #e6edf3;
+    --color-diff-blob-deletion-fg: #e6edf3;
     --color-diff-blob-deletion-num-bg: rgba(212,118,22,0.3);
@@ -17,3 +17,3 @@
     --color-diff-blob-hunk-num-bg: rgba(56,139,253,0.4);
-    --color-diff-blob-expander-icon: #8b949e;
+    --color-diff-blob-expander-icon: #7d8590;
     --color-diff-blob-selected-line-highlight-mix-blend-mode: screen;
@@ -53,3 +53,3 @@
     --color-prettylights-syntax-constant-other-reference-link: #a5d6ff;
-    --color-codemirror-text: #c9d1d9;
+    --color-codemirror-text: #e6edf3;
     --color-codemirror-bg: #0d1117;
@@ -58,7 +58,7 @@
     --color-codemirror-guttermarker-subtle-text: #6e7681;
-    --color-codemirror-linenumber-text: #8b949e;
-    --color-codemirror-cursor: #c9d1d9;
+    --color-codemirror-linenumber-text: #7d8590;
+    --color-codemirror-cursor: #e6edf3;
     --color-codemirror-selection-bg: rgba(56,139,253,0.4);
     --color-codemirror-activeline-bg: rgba(110,118,129,0.1);
-    --color-codemirror-matchingbracket-text: #c9d1d9;
+    --color-codemirror-matchingbracket-text: #e6edf3;
     --color-codemirror-lines-bg: #0d1117;
@@ -75,11 +75,11 @@
     --color-checks-container-border-width: 1px;
-    --color-checks-text-primary: #c9d1d9;
-    --color-checks-text-secondary: #8b949e;
+    --color-checks-text-primary: #e6edf3;
+    --color-checks-text-secondary: #7d8590;
     --color-checks-text-link: #58a6ff;
-    --color-checks-btn-icon: #8b949e;
-    --color-checks-btn-hover-icon: #c9d1d9;
+    --color-checks-btn-icon: #7d8590;
+    --color-checks-btn-hover-icon: #e6edf3;
     --color-checks-btn-hover-bg: rgba(110,118,129,0.1);
-    --color-checks-input-text: #8b949e;
+    --color-checks-input-text: #7d8590;
     --color-checks-input-placeholder-text: #6e7681;
-    --color-checks-input-focus-text: #c9d1d9;
+    --color-checks-input-focus-text: #e6edf3;
     --color-checks-input-bg: #161b22;
@@ -90,3 +90,3 @@
     --color-checks-donut-neutral: #8b949e;
-    --color-checks-dropdown-text: #c9d1d9;
+    --color-checks-dropdown-text: #e6edf3;
     --color-checks-dropdown-bg: #161b22;
@@ -94,12 +94,12 @@
     --color-checks-dropdown-shadow: rgba(1,4,9,0.3);
-    --color-checks-dropdown-hover-text: #c9d1d9;
+    --color-checks-dropdown-hover-text: #e6edf3;
     --color-checks-dropdown-hover-bg: rgba(110,118,129,0.1);
-    --color-checks-dropdown-btn-hover-text: #c9d1d9;
+    --color-checks-dropdown-btn-hover-text: #e6edf3;
     --color-checks-dropdown-btn-hover-bg: rgba(110,118,129,0.1);
     --color-checks-scrollbar-thumb-bg: rgba(110,118,129,0.4);
-    --color-checks-header-label-text: #8b949e;
-    --color-checks-header-label-open-text: #c9d1d9;
+    --color-checks-header-label-text: #7d8590;
+    --color-checks-header-label-open-text: #e6edf3;
     --color-checks-header-border: #21262d;
-    --color-checks-header-icon: #8b949e;
-    --color-checks-line-text: #8b949e;
+    --color-checks-header-icon: #7d8590;
+    --color-checks-line-text: #7d8590;
     --color-checks-line-num-text: #6e7681;
@@ -112,3 +112,3 @@
     --color-checks-gate-bg: rgba(187,128,9,0.15);
-    --color-checks-gate-text: #8b949e;
+    --color-checks-gate-text: #7d8590;
     --color-checks-gate-waiting-text: #d29922;
@@ -117,9 +117,9 @@
     --color-checks-step-warning-text: #d29922;
-    --color-checks-logline-text: #8b949e;
+    --color-checks-logline-text: #7d8590;
     --color-checks-logline-num-text: #6e7681;
     --color-checks-logline-debug-text: #a371f7;
-    --color-checks-logline-error-text: #8b949e;
+    --color-checks-logline-error-text: #7d8590;
     --color-checks-logline-error-num-text: #6e7681;
     --color-checks-logline-error-bg: rgba(212,118,22,0.15);
-    --color-checks-logline-warning-text: #8b949e;
+    --color-checks-logline-warning-text: #7d8590;
     --color-checks-logline-warning-num-text: #d29922;
@@ -265,3 +265,3 @@
     --color-switch-track-disabled-bg: #21262d;
-    --color-switch-track-fg: #8b949e;
+    --color-switch-track-fg: #7d8590;
     --color-switch-track-disabled-fg: #010409;
@@ -286,5 +286,5 @@
     --color-tree-view-item-chevron-hover-bg: rgba(177,186,196,0.12);
-    --color-tree-view-item-directory-fill: #8b949e;
-    --color-fg-default: #c9d1d9;
-    --color-fg-muted: #8b949e;
+    --color-tree-view-item-directory-fill: #7d8590;
+    --color-fg-default: #e6edf3;
+    --color-fg-muted: #7d8590;
     --color-fg-subtle: #6e7681;
--- base/dist/scss/colors/_dark_dimmed.scss	2023-03-29 07:17:43.025778781 +0000
+++ dist/scss/colors/_dark_dimmed.scss	2023-03-29 07:16:26.789757740 +0000
@@ -6,4 +6,4 @@
     --color-marketing-icon-secondary: #316dca;
-    --color-diff-blob-addition-num-text: #adbac7;
-    --color-diff-blob-addition-fg: #adbac7;
+    --color-diff-blob-addition-num-text: #e6edf3;
+    --color-diff-blob-addition-fg: #e6edf3;
     --color-diff-blob-addition-num-bg: rgba(87,171,90,0.3);
@@ -11,4 +11,4 @@
     --color-diff-blob-addition-word-bg: rgba(70,149,74,0.4);
-    --color-diff-blob-deletion-num-text: #adbac7;
-    --color-diff-blob-deletion-fg: #adbac7;
+    --color-diff-blob-deletion-num-text: #e6edf3;
+    --color-diff-blob-deletion-fg: #e6edf3;
     --color-diff-blob-deletion-num-bg: rgba(229,83,75,0.3);
@@ -17,3 +17,3 @@
     --color-diff-blob-hunk-num-bg: rgba(65,132,228,0.4);
-    --color-diff-blob-expander-icon: #768390;
+    --color-diff-blob-expander-icon: #7d8590;
     --color-diff-blob-selected-line-highlight-mix-blend-mode: screen;
@@ -53,3 +53,3 @@
     --color-prettylights-syntax-constant-other-reference-link: #96d0ff;
-    --color-codemirror-text: #adbac7;
+    --color-codemirror-text: #e6edf3;
     --color-codemirror-bg: #22272e;
@@ -58,7 +58,7 @@
     --color-codemirror-guttermarker-subtle-text: #636e7b;
-    --color-codemirror-linenumber-text: #768390;
-    --color-codemirror-cursor: #adbac7;
+    --color-codemirror-linenumber-text: #7d8590;
+    --color-codemirror-cursor: #e6edf3;
     --color-codemirror-selection-bg: rgba(65,132,228,0.4);
     --color-codemirror-activeline-bg: rgba(99,110,123,0.1);
-    --color-codemirror-matchingbracket-text: #adbac7;
+    --color-codemirror-matchingbracket-text: #e6edf3;
     --color-codemirror-lines-bg: #22272e;
@@ -75,11 +75,11 @@
     --color-checks-container-border-width: 1px;
-    --color-checks-text-primary: #adbac7;
-    --color-checks-text-secondary: #768390;
+    --color-checks-text-primary: #e6edf3;
+    --color-checks-text-secondary: #7d8590;
     --color-checks-text-link: #539bf5;
-    --color-checks-btn-icon: #768390;
-    --color-checks-btn-hover-icon: #adbac7;
+    --color-checks-btn-icon: #7d8590;
+    --color-checks-btn-hover-icon: #e6edf3;
     --color-checks-btn-hover-bg: rgba(99,110,123,0.1);
-    --color-checks-input-text: #768390;
+    --color-checks-input-text: #7d8590;
     --color-checks-input-placeholder-text: #636e7b;
-    --color-checks-input-focus-text: #adbac7;
+    --color-checks-input-focus-text: #e6edf3;
     --color-checks-input-bg: #2d333b;
@@ -90,3 +90,3 @@
     --color-checks-donut-neutral: #768390;
-    --color-checks-dropdown-text: #adbac7;
+    --color-checks-dropdown-text: #e6edf3;
     --color-checks-dropdown-bg: #2d333b;
@@ -94,12 +94,12 @@
     --color-checks-dropdown-shadow: rgba(28,33,40,0.3);
-    --color-checks-dropdown-hover-text: #adbac7;
+    --color-checks-dropdown-hover-text: #e6edf3;
     --color-checks-dropdown-hover-bg: rgba(99,110,123,0.1);
-    --color-checks-dropdown-btn-hover-text: #adbac7;
+    --color-checks-dropdown-btn-hover-text: #e6edf3;
     --color-checks-dropdown-btn-hover-bg: rgba(99,110,123,0.1);
     --color-checks-scrollbar-thumb-bg: rgba(99,110,123,0.4);
-    --color-checks-header-label-text: #768390;
-    --color-checks-header-label-open-text: #adbac7;
+    --color-checks-header-label-text: #7d8590;
+    --color-checks-header-label-open-text: #e6edf3;
     --color-checks-header-border: #373e47;
-    --color-checks-header-icon: #768390;
-    --color-checks-line-text: #768390;
+    --color-checks-header-icon: #7d8590;
+    --color-checks-line-text: #7d8590;
     --color-checks-line-num-text: #636e7b;
@@ -112,3 +112,3 @@
     --color-checks-gate-bg: rgba(174,124,20,0.15);
-    --color-checks-gate-text: #768390;
+    --color-checks-gate-text: #7d8590;
     --color-checks-gate-waiting-text: #c69026;
@@ -117,9 +117,9 @@
     --color-checks-step-warning-text: #c69026;
-    --color-checks-logline-text: #768390;
+    --color-checks-logline-text: #7d8590;
     --color-checks-logline-num-text: #636e7b;
     --color-checks-logline-debug-text: #986ee2;
-    --color-checks-logline-error-text: #768390;
+    --color-checks-logline-error-text: #7d8590;
     --color-checks-logline-error-num-text: #636e7b;
     --color-checks-logline-error-bg: rgba(229,83,75,0.15);
-    --color-checks-logline-warning-text: #768390;
+    --color-checks-logline-warning-text: #7d8590;
     --color-checks-logline-warning-num-text: #c69026;
@@ -265,3 +265,3 @@
     --color-switch-track-disabled-bg: #373e47;
-    --color-switch-track-fg: #768390;
+    --color-switch-track-fg: #7d8590;
     --color-switch-track-disabled-fg: #1c2128;
@@ -286,5 +286,5 @@
     --color-tree-view-item-chevron-hover-bg: rgba(144,157,171,0.12);
-    --color-tree-view-item-directory-fill: #768390;
-    --color-fg-default: #adbac7;
-    --color-fg-muted: #768390;
+    --color-tree-view-item-directory-fill: #7d8590;
+    --color-fg-default: #e6edf3;
+    --color-fg-muted: #7d8590;
     --color-fg-subtle: #636e7b;
--- base/dist/scss/colors/_dark_high_contrast.scss	2023-03-29 07:17:43.033779206 +0000
+++ dist/scss/colors/_dark_high_contrast.scss	2023-03-29 07:16:26.793757963 +0000
@@ -6,3 +6,3 @@
     --color-marketing-icon-secondary: #409eff;
-    --color-diff-blob-addition-num-text: #f0f3f6;
+    --color-diff-blob-addition-num-text: #e6edf3;
     --color-diff-blob-addition-fg: #0a0c10;
@@ -11,3 +11,3 @@
     --color-diff-blob-addition-word-bg: #09b43a;
-    --color-diff-blob-deletion-num-text: #f0f3f6;
+    --color-diff-blob-deletion-num-text: #e6edf3;
     --color-diff-blob-deletion-fg: #0a0c10;
@@ -17,3 +17,3 @@
     --color-diff-blob-hunk-num-bg: rgba(64,158,255,0.4);
-    --color-diff-blob-expander-icon: #f0f3f6;
+    --color-diff-blob-expander-icon: #e6edf3;
     --color-diff-blob-selected-line-highlight-mix-blend-mode: screen;
@@ -53,3 +53,3 @@
     --color-prettylights-syntax-constant-other-reference-link: #addcff;
-    --color-codemirror-text: #f0f3f6;
+    --color-codemirror-text: #e6edf3;
     --color-codemirror-bg: #0a0c10;
@@ -59,6 +59,6 @@
     --color-codemirror-linenumber-text: #f0f3f6;
-    --color-codemirror-cursor: #f0f3f6;
+    --color-codemirror-cursor: #e6edf3;
     --color-codemirror-selection-bg: rgba(64,158,255,0.4);
     --color-codemirror-activeline-bg: rgba(158,167,179,0.1);
-    --color-codemirror-matchingbracket-text: #f0f3f6;
+    --color-codemirror-matchingbracket-text: #e6edf3;
     --color-codemirror-lines-bg: #0a0c10;
@@ -75,3 +75,3 @@
     --color-checks-container-border-width: 1px;
-    --color-checks-text-primary: #f0f3f6;
+    --color-checks-text-primary: #e6edf3;
     --color-checks-text-secondary: #f0f3f6;
@@ -79,3 +79,3 @@
     --color-checks-btn-icon: #f0f3f6;
-    --color-checks-btn-hover-icon: #f0f3f6;
+    --color-checks-btn-hover-icon: #e6edf3;
     --color-checks-btn-hover-bg: rgba(158,167,179,0.1);
@@ -83,3 +83,3 @@
     --color-checks-input-placeholder-text: #9ea7b3;
-    --color-checks-input-focus-text: #f0f3f6;
+    --color-checks-input-focus-text: #e6edf3;
     --color-checks-input-bg: #272b33;
@@ -90,3 +90,3 @@
     --color-checks-donut-neutral: #bdc4cc;
-    --color-checks-dropdown-text: #f0f3f6;
+    --color-checks-dropdown-text: #e6edf3;
     --color-checks-dropdown-bg: #272b33;
@@ -94,5 +94,5 @@
     --color-checks-dropdown-shadow: rgba(1,4,9,0.3);
-    --color-checks-dropdown-hover-text: #f0f3f6;
+    --color-checks-dropdown-hover-text: #e6edf3;
     --color-checks-dropdown-hover-bg: rgba(158,167,179,0.1);
-    --color-checks-dropdown-btn-hover-text: #f0f3f6;
+    --color-checks-dropdown-btn-hover-text: #e6edf3;
     --color-checks-dropdown-btn-hover-bg: rgba(158,167,179,0.1);
@@ -100,3 +100,3 @@
     --color-checks-header-label-text: #f0f3f6;
-    --color-checks-header-label-open-text: #f0f3f6;
+    --color-checks-header-label-open-text: #e6edf3;
     --color-checks-header-border: #7a828e;
@@ -287,3 +287,3 @@
     --color-tree-view-item-directory-fill: #f0f3f6;
-    --color-fg-default: #f0f3f6;
+    --color-fg-default: #e6edf3;
     --color-fg-muted: #f0f3f6;
--- base/dist/scss/colors/_dark_tritanopia.scss	2023-03-29 07:17:43.041779632 +0000
+++ dist/scss/colors/_dark_tritanopia.scss	2023-03-29 07:16:26.805758631 +0000
@@ -6,4 +6,4 @@
     --color-marketing-icon-secondary: #1f6feb;
-    --color-diff-blob-addition-num-text: #c9d1d9;
-    --color-diff-blob-addition-fg: #c9d1d9;
+    --color-diff-blob-addition-num-text: #e6edf3;
+    --color-diff-blob-addition-fg: #e6edf3;
     --color-diff-blob-addition-num-bg: rgba(88,166,255,0.3);
@@ -11,4 +11,4 @@
     --color-diff-blob-addition-word-bg: rgba(56,139,253,0.4);
-    --color-diff-blob-deletion-num-text: #c9d1d9;
-    --color-diff-blob-deletion-fg: #c9d1d9;
+    --color-diff-blob-deletion-num-text: #e6edf3;
+    --color-diff-blob-deletion-fg: #e6edf3;
     --color-diff-blob-deletion-num-bg: rgba(248,81,73,0.3);
@@ -17,3 +17,3 @@
     --color-diff-blob-hunk-num-bg: rgba(56,139,253,0.4);
-    --color-diff-blob-expander-icon: #8b949e;
+    --color-diff-blob-expander-icon: #7d8590;
     --color-diff-blob-selected-line-highlight-mix-blend-mode: screen;
@@ -53,3 +53,3 @@
     --color-prettylights-syntax-constant-other-reference-link: #a5d6ff;
-    --color-codemirror-text: #c9d1d9;
+    --color-codemirror-text: #e6edf3;
     --color-codemirror-bg: #0d1117;
@@ -58,7 +58,7 @@
     --color-codemirror-guttermarker-subtle-text: #6e7681;
-    --color-codemirror-linenumber-text: #8b949e;
-    --color-codemirror-cursor: #c9d1d9;
+    --color-codemirror-linenumber-text: #7d8590;
+    --color-codemirror-cursor: #e6edf3;
     --color-codemirror-selection-bg: rgba(56,139,253,0.4);
     --color-codemirror-activeline-bg: rgba(110,118,129,0.1);
-    --color-codemirror-matchingbracket-text: #c9d1d9;
+    --color-codemirror-matchingbracket-text: #e6edf3;
     --color-codemirror-lines-bg: #0d1117;
@@ -75,11 +75,11 @@
     --color-checks-container-border-width: 1px;
-    --color-checks-text-primary: #c9d1d9;
-    --color-checks-text-secondary: #8b949e;
+    --color-checks-text-primary: #e6edf3;
+    --color-checks-text-secondary: #7d8590;
     --color-checks-text-link: #58a6ff;
-    --color-checks-btn-icon: #8b949e;
-    --color-checks-btn-hover-icon: #c9d1d9;
+    --color-checks-btn-icon: #7d8590;
+    --color-checks-btn-hover-icon: #e6edf3;
     --color-checks-btn-hover-bg: rgba(110,118,129,0.1);
-    --color-checks-input-text: #8b949e;
+    --color-checks-input-text: #7d8590;
     --color-checks-input-placeholder-text: #6e7681;
-    --color-checks-input-focus-text: #c9d1d9;
+    --color-checks-input-focus-text: #e6edf3;
     --color-checks-input-bg: #161b22;
@@ -90,3 +90,3 @@
     --color-checks-donut-neutral: #8b949e;
-    --color-checks-dropdown-text: #c9d1d9;
+    --color-checks-dropdown-text: #e6edf3;
     --color-checks-dropdown-bg: #161b22;
@@ -94,12 +94,12 @@
     --color-checks-dropdown-shadow: rgba(1,4,9,0.3);
-    --color-checks-dropdown-hover-text: #c9d1d9;
+    --color-checks-dropdown-hover-text: #e6edf3;
     --color-checks-dropdown-hover-bg: rgba(110,118,129,0.1);
-    --color-checks-dropdown-btn-hover-text: #c9d1d9;
+    --color-checks-dropdown-btn-hover-text: #e6edf3;
     --color-checks-dropdown-btn-hover-bg: rgba(110,118,129,0.1);
     --color-checks-scrollbar-thumb-bg: rgba(110,118,129,0.4);
-    --color-checks-header-label-text: #8b949e;
-    --color-checks-header-label-open-text: #c9d1d9;
+    --color-checks-header-label-text: #7d8590;
+    --color-checks-header-label-open-text: #e6edf3;
     --color-checks-header-border: #21262d;
-    --color-checks-header-icon: #8b949e;
-    --color-checks-line-text: #8b949e;
+    --color-checks-header-icon: #7d8590;
+    --color-checks-line-text: #7d8590;
     --color-checks-line-num-text: #6e7681;
@@ -112,3 +112,3 @@
     --color-checks-gate-bg: rgba(187,128,9,0.15);
-    --color-checks-gate-text: #8b949e;
+    --color-checks-gate-text: #7d8590;
     --color-checks-gate-waiting-text: #d29922;
@@ -117,9 +117,9 @@
     --color-checks-step-warning-text: #d29922;
-    --color-checks-logline-text: #8b949e;
+    --color-checks-logline-text: #7d8590;
     --color-checks-logline-num-text: #6e7681;
     --color-checks-logline-debug-text: #a371f7;
-    --color-checks-logline-error-text: #8b949e;
+    --color-checks-logline-error-text: #7d8590;
     --color-checks-logline-error-num-text: #6e7681;
     --color-checks-logline-error-bg: rgba(248,81,73,0.15);
-    --color-checks-logline-warning-text: #8b949e;
+    --color-checks-logline-warning-text: #7d8590;
     --color-checks-logline-warning-num-text: #d29922;
@@ -265,3 +265,3 @@
     --color-switch-track-disabled-bg: #21262d;
-    --color-switch-track-fg: #8b949e;
+    --color-switch-track-fg: #7d8590;
     --color-switch-track-disabled-fg: #010409;
@@ -286,5 +286,5 @@
     --color-tree-view-item-chevron-hover-bg: rgba(177,186,196,0.12);
-    --color-tree-view-item-directory-fill: #8b949e;
-    --color-fg-default: #c9d1d9;
-    --color-fg-muted: #8b949e;
+    --color-tree-view-item-directory-fill: #7d8590;
+    --color-fg-default: #e6edf3;
+    --color-fg-muted: #7d8590;
     --color-fg-subtle: #6e7681;

@github-actions

github-actions Bot commented Mar 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

🟢 No design token changes found

@lukasoppermann
lukasoppermann temporarily deployed to github-pages March 14, 2023 16:17 — with GitHub Actions Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview March 14, 2023 16:17 Inactive
@github-actions
github-actions Bot temporarily deployed to storybook-preview March 29, 2023 07:20 Inactive
@lukasoppermann
lukasoppermann merged commit 9624229 into main Mar 29, 2023
@lukasoppermann
lukasoppermann deleted the a11y/darkmode-text branch March 29, 2023 07:34
@lukasoppermann lukasoppermann mentioned this pull request Mar 29, 2023
Merged
wh0 pushed a commit to wh0/iswas that referenced this pull request Apr 8, 2023
w
update text colors
eee4bc9 
cross reference: primer/primitives#515
cross reference: primer/primitives#516

This branch was previously deployed

2 inactive deployments
storybook-preview — 34b48983 Deployed Mar 29, 2023 by github-actions[bot]
github-pages — 34b48983 Deployed Mar 29, 2023 by lukasoppermann
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simurai simurai simurai approved these changes
@langermank langermank Awaiting requested review from langermank

Assignees

@lukasoppermann lukasoppermann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukasoppermann @simurai