Repository navigation
A11y update to fix contrast issue with primary green - #514
Merged
Merged
Conversation
|
Contributor
Variables changed--- base/dist/scss/colors/_light.scss 2023-03-29 07:38:45.551777692 +0000
+++ dist/scss/colors/_light.scss 2023-03-29 07:37:39.419164623 +0000
@@ -21,3 +21,3 @@
--color-diffstat-addition-border: rgba(31,35,40,0.15);
- --color-diffstat-addition-bg: #2da44e;
+ --color-diffstat-addition-bg: #1f883d;
--color-search-keyword-hl: #fff8c5;
@@ -88,3 +88,3 @@
--color-checks-donut-pending: #bf8700;
- --color-checks-donut-success: #2da44e;
+ --color-checks-donut-success: #1f883d;
--color-checks-donut-neutral: #afb8c1;
@@ -205,3 +205,3 @@
--color-btn-primary-text: #ffffff;
- --color-btn-primary-bg: #2da44e;
+ --color-btn-primary-bg: #1f883d;
--color-btn-primary-border: rgba(31,35,40,0.15);
@@ -209,5 +209,5 @@
--color-btn-primary-inset-shadow: inset 0 1px 0 rgba(255,255,255,0.03);
- --color-btn-primary-hover-bg: #2c974b;
+ --color-btn-primary-hover-bg: #1a7f37;
--color-btn-primary-hover-border: rgba(31,35,40,0.15);
- --color-btn-primary-selected-bg: hsla(137,55%,36%,1);
+ --color-btn-primary-selected-bg: hsla(137,66%,28%,1);
--color-btn-primary-selected-shadow: inset 0 1px 0 rgba(0,45,17,0.2);
@@ -311,3 +311,3 @@
--color-success-fg: #1a7f37;
- --color-success-emphasis: #2da44e;
+ --color-success-emphasis: #1f883d;
--color-success-muted: rgba(74,194,107,0.4);
@@ -327,3 +327,3 @@
--color-open-fg: #1a7f37;
- --color-open-emphasis: #2da44e;
+ --color-open-emphasis: #1f883d;
--color-open-muted: rgba(74,194,107,0.4);
--- base/dist/scss/colors/_light_colorblind.scss 2023-03-29 07:38:45.567777840 +0000
+++ dist/scss/colors/_light_colorblind.scss 2023-03-29 07:37:39.435164785 +0000
@@ -21,3 +21,3 @@
--color-diffstat-addition-border: rgba(27,31,36,0.15);
- --color-diffstat-addition-bg: #218bff;
+ --color-diffstat-addition-bg: #1f883d;
--color-search-keyword-hl: #fff8c5;
@@ -88,3 +88,3 @@
--color-checks-donut-pending: #bf8700;
- --color-checks-donut-success: #218bff;
+ --color-checks-donut-success: #1f883d;
--color-checks-donut-neutral: #afb8c1;
@@ -205,3 +205,3 @@
--color-btn-primary-text: #ffffff;
- --color-btn-primary-bg: #218bff;
+ --color-btn-primary-bg: #1f883d;
--color-btn-primary-border: rgba(27,31,36,0.15);
@@ -311,3 +311,3 @@
--color-success-fg: #0969da;
- --color-success-emphasis: #218bff;
+ --color-success-emphasis: #1f883d;
--color-success-muted: rgba(84,174,255,0.4);
--- base/dist/scss/colors/_light_high_contrast.scss 2023-03-29 07:38:45.559777766 +0000
+++ dist/scss/colors/_light_high_contrast.scss 2023-03-29 07:37:39.427164704 +0000
@@ -21,3 +21,3 @@
--color-diffstat-addition-border: rgba(1,4,9,0.8);
- --color-diffstat-addition-bg: #117f32;
+ --color-diffstat-addition-bg: #055d20;
--color-search-keyword-hl: #fcf7be;
@@ -88,3 +88,3 @@
--color-checks-donut-pending: #956400;
- --color-checks-donut-success: #117f32;
+ --color-checks-donut-success: #055d20;
--color-checks-donut-neutral: #acb6c0;
@@ -327,3 +327,3 @@
--color-open-fg: #055d20;
- --color-open-emphasis: #117f32;
+ --color-open-emphasis: #055d20;
--color-open-muted: rgba(38,161,72,0.4);
--- base/dist/scss/colors/_light_tritanopia.scss 2023-03-29 07:38:45.575777914 +0000
+++ dist/scss/colors/_light_tritanopia.scss 2023-03-29 07:37:39.443164866 +0000
@@ -21,3 +21,3 @@
--color-diffstat-addition-border: rgba(27,31,36,0.15);
- --color-diffstat-addition-bg: #218bff;
+ --color-diffstat-addition-bg: #1f883d;
--color-search-keyword-hl: #fff8c5;
@@ -88,3 +88,3 @@
--color-checks-donut-pending: #bf8700;
- --color-checks-donut-success: #218bff;
+ --color-checks-donut-success: #1f883d;
--color-checks-donut-neutral: #afb8c1;
@@ -205,3 +205,3 @@
--color-btn-primary-text: #ffffff;
- --color-btn-primary-bg: #218bff;
+ --color-btn-primary-bg: #1f883d;
--color-btn-primary-border: rgba(27,31,36,0.15);
@@ -311,3 +311,3 @@
--color-success-fg: #0969da;
- --color-success-emphasis: #218bff;
+ --color-success-emphasis: #1f883d;
--color-success-muted: rgba(84,174,255,0.4); |
Contributor
🟢 No design token changes found |
lukasoppermann
temporarily deployed
to
github-pages
March 14, 2023 13:31 — with 
GitHub Actions
Inactive
lukasoppermann
requested review from
langermank and
simurai
and removed request for
josepmartins and
tobiasahlin
March 14, 2023 15:16
simurai
reviewed
Mar 15, 2023
simurai
approved these changes
Mar 15, 2023
lukasoppermann
force-pushed
the
a11y/primary-green
branch
from
March 29, 2023 07:24
4466a69 to
71ebeff
Compare
lukasoppermann
had a problem deploying
to
github-pages
March 29, 2023 07:31 — with
GitHub Actions
Failure
lukasoppermann
temporarily deployed
to
github-pages
March 29, 2023 07:41 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the failing contrast between the white text and green button background as part of https://github.com/github/primer/issues/1648.
It addresses both the current (old) implementation as well as the new v3 tokens.