Repository navigation
Fix box shadow on AvatarPair - #499
Merged
Merged
Conversation
π¦ Changeset detectedLatest commit: 19d262d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Variables changed--- base/dist/scss/colors/_dark.scss 2023-02-17 10:30:53.971995925 +0000
+++ dist/scss/colors/_dark.scss 2023-02-17 10:29:47.896537184 +0000
@@ -159,3 +159,3 @@
--color-avatar-stack-fade-more: #21262d;
- --color-avatar-child-shadow: -2px -2px 0 #0d1117;
+ --color-avatar-child-shadow: 0 0 0 2px #0d1117;
--color-topic-tag-border: rgba(0,0,0,0);
--- base/dist/scss/colors/_dark_colorblind.scss 2023-02-17 10:30:53.987995793 +0000
+++ dist/scss/colors/_dark_colorblind.scss 2023-02-17 10:29:47.912537056 +0000
@@ -159,3 +159,3 @@
--color-avatar-stack-fade-more: #21262d;
- --color-avatar-child-shadow: -2px -2px 0 #0d1117;
+ --color-avatar-child-shadow: 0 0 0 2px #0d1117;
--color-topic-tag-border: rgba(0,0,0,0);
--- base/dist/scss/colors/_dark_dimmed.scss 2023-02-17 10:30:53.975995892 +0000
+++ dist/scss/colors/_dark_dimmed.scss 2023-02-17 10:29:47.904537120 +0000
@@ -159,3 +159,3 @@
--color-avatar-stack-fade-more: #373e47;
- --color-avatar-child-shadow: -2px -2px 0 #22272e;
+ --color-avatar-child-shadow: 0 0 0 2px #22272e;
--color-topic-tag-border: rgba(0,0,0,0);
--- base/dist/scss/colors/_dark_high_contrast.scss 2023-02-17 10:30:53.983995826 +0000
+++ dist/scss/colors/_dark_high_contrast.scss 2023-02-17 10:29:47.908537088 +0000
@@ -159,3 +159,3 @@
--color-avatar-stack-fade-more: #272b33;
- --color-avatar-child-shadow: -2px -2px 0 #0a0c10;
+ --color-avatar-child-shadow: 0 0 0 2px #0a0c10;
--color-topic-tag-border: #409eff;
--- base/dist/scss/colors/_dark_tritanopia.scss 2023-02-17 10:30:53.991995760 +0000
+++ dist/scss/colors/_dark_tritanopia.scss 2023-02-17 10:29:47.916537024 +0000
@@ -159,3 +159,3 @@
--color-avatar-stack-fade-more: #21262d;
- --color-avatar-child-shadow: -2px -2px 0 #0d1117;
+ --color-avatar-child-shadow: 0 0 0 2px #0d1117;
--color-topic-tag-border: rgba(0,0,0,0);
--- base/dist/scss/colors/_light.scss 2023-02-17 10:30:53.947996123 +0000
+++ dist/scss/colors/_light.scss 2023-02-17 10:29:47.868537408 +0000
@@ -159,3 +159,3 @@
--color-avatar-stack-fade-more: #d0d7de;
- --color-avatar-child-shadow: -2px -2px 0 rgba(255,255,255,0.8);
+ --color-avatar-child-shadow: 0 0 0 2px rgba(255,255,255,0.8);
--color-topic-tag-border: rgba(0,0,0,0);
--- base/dist/scss/colors/_light_colorblind.scss 2023-02-17 10:30:53.959996024 +0000
+++ dist/scss/colors/_light_colorblind.scss 2023-02-17 10:29:47.892537216 +0000
@@ -159,3 +159,3 @@
--color-avatar-stack-fade-more: #d0d7de;
- --color-avatar-child-shadow: -2px -2px 0 rgba(255,255,255,0.8);
+ --color-avatar-child-shadow: 0 0 0 2px rgba(255,255,255,0.8);
--color-topic-tag-border: rgba(0,0,0,0);
--- base/dist/scss/colors/_light_high_contrast.scss 2023-02-17 10:30:53.955996057 +0000
+++ dist/scss/colors/_light_high_contrast.scss 2023-02-17 10:29:47.884537280 +0000
@@ -159,3 +159,3 @@
--color-avatar-stack-fade-more: #ced5dc;
- --color-avatar-child-shadow: -2px -2px 0 rgba(255,255,255,0.8);
+ --color-avatar-child-shadow: 0 0 0 2px rgba(255,255,255,0.8);
--color-topic-tag-border: #0349b4;
--- base/dist/scss/colors/_light_tritanopia.scss 2023-02-17 10:30:53.967995958 +0000
+++ dist/scss/colors/_light_tritanopia.scss 2023-02-17 10:29:47.896537184 +0000
@@ -159,3 +159,3 @@
--color-avatar-stack-fade-more: #d0d7de;
- --color-avatar-child-shadow: -2px -2px 0 rgba(255,255,255,0.8);
+ --color-avatar-child-shadow: 0 0 0 2px rgba(255,255,255,0.8);
--color-topic-tag-border: rgba(0,0,0,0); |
Contributor
π’ No design token changes found |
josepmartins
temporarily deployed
to
github-pages
February 17, 2023 10:21 — with 
GitHub Actions
Inactive
josepmartins
temporarily deployed
to
github-pages
February 17, 2023 10:35 — with
GitHub Actions
Inactive
lukasoppermann
approved these changes
Feb 17, 2023
lukasoppermann
left a comment
Collaborator
There was a problem hiding this comment.
Great spotting this. π
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixing a box-shadow bug in the
AvatarPairchildren. The shadow was relatively positioned using offset-x and offset-y values (-2px). This PR uses aspread-radiusof2pxinstead, the same styles we use on the Avatar box-shadow here. This works both for non-square and square variants.List of notable changes:
Steps to test:
Contributor checklist:
Reviewer checklist: