Repository navigation
Adds TreeView component color primitives - #354
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1368162 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Variables changed--- base/dist/scss/colors/_dark.scss 2022-09-21 17:17:40.694778180 +0000
+++ dist/scss/colors/_dark.scss 2022-09-21 17:17:27.046886574 +0000
@@ -284,2 +284,3 @@
--color-segmented-control-button-selected-border: #6e7681;
+ --color-tree-view-item-chevron-hover-bg: rgba(177,186,196,0.12);
--color-fg-default: #c9d1d9;
--- base/dist/scss/colors/_dark_colorblind.scss 2022-09-21 17:17:40.714777960 +0000
+++ dist/scss/colors/_dark_colorblind.scss 2022-09-21 17:17:27.062886313 +0000
@@ -284,2 +284,3 @@
--color-segmented-control-button-selected-border: #6e7681;
+ --color-tree-view-item-chevron-hover-bg: rgba(177,186,196,0.12);
--color-fg-default: #c9d1d9;
--- base/dist/scss/colors/_dark_dimmed.scss 2022-09-21 17:17:40.706778048 +0000
+++ dist/scss/colors/_dark_dimmed.scss 2022-09-21 17:17:27.054886444 +0000
@@ -284,2 +284,3 @@
--color-segmented-control-button-selected-border: #636e7b;
+ --color-tree-view-item-chevron-hover-bg: rgba(144,157,171,0.12);
--color-fg-default: #adbac7;
--- base/dist/scss/colors/_dark_high_contrast.scss 2022-09-21 17:17:40.710778004 +0000
+++ dist/scss/colors/_dark_high_contrast.scss 2022-09-21 17:17:27.058886378 +0000
@@ -284,2 +284,3 @@
--color-segmented-control-button-selected-border: #9ea7b3;
+ --color-tree-view-item-chevron-hover-bg: #525964;
--color-fg-default: #f0f3f6;
--- base/dist/scss/colors/_dark_tritanopia.scss 2022-09-21 17:17:40.718777916 +0000
+++ dist/scss/colors/_dark_tritanopia.scss 2022-09-21 17:17:27.066886248 +0000
@@ -284,2 +284,3 @@
--color-segmented-control-button-selected-border: #6e7681;
+ --color-tree-view-item-chevron-hover-bg: rgba(177,186,196,0.12);
--color-fg-default: #c9d1d9;
--- base/dist/scss/colors/_light.scss 2022-09-21 17:17:40.666778489 +0000
+++ dist/scss/colors/_light.scss 2022-09-21 17:17:27.018887030 +0000
@@ -284,2 +284,3 @@
--color-segmented-control-button-selected-border: #6e7781;
+ --color-tree-view-item-chevron-hover-bg: rgba(208,215,222,0.32);
--color-fg-default: #24292f;
--- base/dist/scss/colors/_light_colorblind.scss 2022-09-21 17:17:40.682778313 +0000
+++ dist/scss/colors/_light_colorblind.scss 2022-09-21 17:17:27.038886704 +0000
@@ -284,2 +284,3 @@
--color-segmented-control-button-selected-border: #6e7781;
+ --color-tree-view-item-chevron-hover-bg: rgba(208,215,222,0.32);
--color-fg-default: #24292f;
--- base/dist/scss/colors/_light_high_contrast.scss 2022-09-21 17:17:40.678778357 +0000
+++ dist/scss/colors/_light_high_contrast.scss 2022-09-21 17:17:27.030886835 +0000
@@ -284,2 +284,3 @@
--color-segmented-control-button-selected-border: #66707b;
+ --color-tree-view-item-chevron-hover-bg: #ced5dc;
--color-fg-default: #0e1116;
--- base/dist/scss/colors/_light_tritanopia.scss 2022-09-21 17:17:40.690778224 +0000
+++ dist/scss/colors/_light_tritanopia.scss 2022-09-21 17:17:27.042886639 +0000
@@ -284,2 +284,3 @@
--color-segmented-control-button-selected-border: #6e7781;
+ --color-tree-view-item-chevron-hover-bg: rgba(208,215,222,0.32);
--color-fg-default: #24292f; |
Contributor
🟢 No design token changes found |
colebemis
reviewed
Sep 21, 2022
Co-authored-by: Cole Bemis <colebemis@github.com>
colebemis
reviewed
Sep 21, 2022
Co-authored-by: Cole Bemis <colebemis@github.com>
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using
actionListItem.default.hoverBgfor both the chevron hover background color and the node hover background color. This was a problem because that color has no transparency, so they were indistinguishable when stacked on top of eachother.I opted for adding TreeView-specific primitives instead of global primitives. I don't see another use case for stacked hover colors. We can reconsider adding a global primitives when/if that case comes up.
Before
After
