Repository navigation
add self serve tooling for new primitives - #323
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 8fc70d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/ct8vQ6Wvf8dePPenMsdPqvXYfyFm |
Contributor
Variables changedNo variables changed |
langermank
approved these changes
Apr 27, 2022
langermank
left a comment
Contributor
There was a problem hiding this comment.
Incredible work Reza! I pulled and built locally, everything looks good to me 👍
…ves into rezrah/self-serve-tooling
Merged
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing?
Refactoring v2 tokens to build and export self-serve primitives from
@primer/primitives🎥 Check out the demo: https://www.loom.com/share/a300e866498844bba551fc4b5c6795ae
Why?
Part of https://github.com/github/primer/issues/924
Primer Brand is expected to generate its own primitives, rather than importing the product tokens from in
@primer/primitives.See epic for more details: https://github.com/github/primer/issues/924
How?