Repository navigation
Add Tritanopia theme - #310
Conversation
🦋 Changeset detectedLatest commit: 251de59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/GHNYUQ1yBZC6jQg8U1PDTJgbvngb |
Variables changedNo variables changed |
| @@ -0,0 +1,62 @@ | |||
| import {merge} from '../../../src/utils' | |||
| import light_colorblind from './light_colorblind' | |||
There was a problem hiding this comment.
Is it ok to import light_colorblind directly (instead of light)? It avoids us having to keep the colorblind exceptions in sync.
There was a problem hiding this comment.
I think we built it with this intention in mind. cc @colebemis to verify
|
@jonrohan do you have capacity to hop in on this review this week to help get color modes to beta? |
| @@ -0,0 +1,62 @@ | |||
| import {merge} from '../../../src/utils' | |||
| import light_colorblind from './light_colorblind' | |||
There was a problem hiding this comment.
I think we built it with this intention in mind. cc @colebemis to verify
This is in support of https://github.com/github/primer/issues/844 and adds 2 new
light_tritanopiaanddark_tritanopiathemes.They are identical to the
colorblindthemes except for:orangescale use the values from the defaultredscaleredscale use the values from the defaultredscaleHere the effect on the open
Statecomponent:And here a simulation how a user with Tritanopia might see the open
State. It looks "red" in both themes but a bit more vibrant in the Tritanopia theme: