Skip to content

Update closed role for dark_colorblind - #303

Merged
simurai merged 2 commits into
mainfrom
update-closed-colorblind
Mar 4, 2022
Merged

simurai merged 2 commits into
mainfrom
update-closed-colorblind

Conversation

@simurai

@simurai simurai commented Mar 4, 2022 •

Copy link
Copy Markdown
Contributor

This is a follow-up to #296. It increases contrast for the closed role in dark_colorblind.

Before After
Screen Shot 2022-03-04 at 16 36 34 Screen Shot 2022-03-04 at 16 36 41
Screen Shot 2022-03-04 at 16 16 45 Screen Shot 2022-03-04 at 16 35 55
Before After
Screen Shot 2022-03-04 at 16 40 23 Screen Shot 2022-03-04 at 16 40 35

/cc @Juliusschaeper

@changeset-bot

changeset-bot Bot commented Mar 4, 2022 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c47dec0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Mar 4, 2022 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/m9v1osKpg4cuvTPiK2VowguQ2pfC
âś… Preview: https://primitives-git-update-closed-colorblind-primer.vercel.app

@github-actions

github-actions Bot commented Mar 4, 2022 •

Copy link
Copy Markdown
Contributor
Variables changed
--- base/dist/scss/colors/_dark_colorblind.scss	2022-03-04 07:32:50.902448747 +0000
+++ dist/scss/colors/_dark_colorblind.scss	2022-03-04 07:32:40.446537650 +0000
@@ -315,6 +315,6 @@
     --color-open-subtle: rgba(219,109,40,0.15);
-    --color-closed-fg: #6e7681;
-    --color-closed-emphasis: #484f58;
+    --color-closed-fg: #8b949e;
+    --color-closed-emphasis: #6e7681;
     --color-closed-muted: rgba(110,118,129,0.4);
-    --color-closed-subtle: rgba(110,118,129,0.15);
+    --color-closed-subtle: rgba(110,118,129,0.1);
     --color-done-fg: #a371f7;

@simurai
simurai marked this pull request as ready for review March 4, 2022 07:45
@simurai
simurai requested a review from a team as a code owner March 4, 2022 07:45
@simurai
simurai requested review from a team, colebemis and langermank March 4, 2022 07:45
@simurai
simurai merged commit 07e01ad into main Mar 4, 2022
@simurai
simurai deleted the update-closed-colorblind branch March 4, 2022 11:57
@primer-css primer-css mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant