Repository navigation
[Actions] Update light theme color for gateWaitingText - #301
Merged
Merged
Conversation
π¦ Changeset detectedLatest commit: 4a0fc7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). π Inspect: https://vercel.com/primer/primitives/ZbpMCiEhc3mW5UvMUrKGD7ad6uE5 |
simurai
approved these changes
Mar 2, 2022
simurai
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me. π
@konradpabjan thanks for the fix. π
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/github/c2c-actions-checks/issues/242
Currently the warning text color is incorrect but only in the light theme:
This will update the warning text to match warnings in logs:
Current incorrect color
With updated color
In our codebase we have
color: var(--color-checks-gate-waiting-text);This matches the same color we have for warnings in our logs for the light theme
This is exactly what
stepWarningText: get('scale.yellow.3'),is