Repository navigation
Improved contrast for change highlights in diff - #274
Conversation
wordBg → emphasis word foreground → onEmphasis This increases contrast for change highlights to background and foreground.
🦋 Changeset detectedLatest commit: b9a6608 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/HqU7bTminBLxrrM2bA1D31Ncnrcd |
Variables changed--- base/dist/scss/colors/_light_high_contrast.scss 2021-11-23 00:58:45.156460222 +0000
+++ dist/scss/colors/_light_high_contrast.scss 2021-11-23 00:58:33.483704170 +0000
@@ -6,12 +6,12 @@
--color-diff-blob-addition-num-text: #24292F;
- --color-diff-blob-addition-fg: #24292F;
+ --color-diff-blob-addition-fg: #ffffff;
--color-diff-blob-addition-num-bg: #CCFFD8;
--color-diff-blob-addition-line-bg: #E6FFEC;
- --color-diff-blob-addition-word-bg: #ABF2BC;
+ --color-diff-blob-addition-word-bg: #055d20;
--color-diff-blob-deletion-num-text: #24292F;
- --color-diff-blob-deletion-fg: #24292F;
+ --color-diff-blob-deletion-fg: #ffffff;
--color-diff-blob-deletion-num-bg: #FFD7D5;
--color-diff-blob-deletion-line-bg: #fff0ee;
- --color-diff-blob-deletion-word-bg: #ee5a5d;
- --color-diff-blob-hunk-num-bg: #368cf9;
+ --color-diff-blob-deletion-word-bg: #a0111f;
+ --color-diff-blob-hunk-num-bg: #9cd7ff;
--color-diff-blob-expander-icon: #24292F; |
simurai
left a comment
There was a problem hiding this comment.
@Juliusschaeper Is this PR meant to change also the diff for the Light default theme?
If it's meant only for Light high contrast, then I guess it would need to be an exception.
For some reason I changed everything in default light instead added it to light high contrast exceptions. This is now fixed.
|
@simurai Thanks for noticing this issue 🙈 I reverted my changes and moved the adjustments over to light high contrast exceptions. |
wordBg → emphasis
word foreground → onEmphasis
This increases contrast for change highlights to background and foreground.