Skip to content

Mark mktg primitives as removed - #269

Merged
simurai merged 2 commits into
mainfrom
mark-mktg-btn-as-removed
Nov 9, 2021
Merged

simurai merged 2 commits into
mainfrom
mark-mktg-btn-as-removed

Conversation

@simurai

@simurai simurai commented Nov 9, 2021 •

Copy link
Copy Markdown
Contributor

This is a follow-up to #265 and adds the removed primitives to data/colors/removed.json.

Note that all primitives have a replacement of null since I think this isn't really a 1:1 replacement and more a rewrite of the button components. /cc @tobiasahlin

@simurai
simurai requested a review from a team as a code owner November 9, 2021 01:27
@simurai
simurai requested review from a team, langermank and siddharthkp November 9, 2021 01:27
@vercel

vercel Bot commented Nov 9, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/2snYUXrxsoDGN7gBLBn76eHQEgWV
âś… Preview: https://primitives-git-mark-mktg-btn-as-removed-primer.vercel.app

@changeset-bot

changeset-bot Bot commented Nov 9, 2021 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 811caef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Nov 9, 2021 •

Copy link
Copy Markdown
Contributor
Variables changed
No variables changed

@simurai simurai changed the title Remove mktg primitives Mark mktg primitives as removed Nov 9, 2021
@simurai
simurai merged commit f16073c into main Nov 9, 2021
@simurai
simurai deleted the mark-mktg-btn-as-removed branch November 9, 2021 01:36
@primer-css primer-css mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant