Repository navigation
Map border.tertiary to border.default - #242
Merged
Merged
Conversation
π¦ Changeset detectedLatest commit: ba564a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). π Inspect: https://vercel.com/primer/primitives/BW5cf4ZKKzikueQ1kTBWvmUXUyc5 |
colebemis
approved these changes
Sep 22, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This maps the deprecated
border.tertiarytoborder.default.Reasoning
This came up in primer/css#1615. The history seems to be:
border-gray-darkwas the "strongest", most contrasting border colorcolor-border-tertiarywhich probably suggests it's the "weakest", but the color was still stronger than the default border..border-gray-dark->.color-border-tertiary->.color-border-defaultHere a screenshot of
color-border-tertiaryfrom v1:Keeping the current
color-neutral-subtlewould make the border barely visible:We might also want to change all the
border-tertiary->neutral-mutedmigrations in https://github.com/github/github/pull/192360 toborder-default. E.g. the border for this "Load more" button would be pretty hard to see:/cc @ashygee