Skip to content

Update timeline-badge-bg - #217

Merged
simurai merged 2 commits into
mainfrom
timeline-badge-bg
Aug 26, 2021
Merged

simurai merged 2 commits into
mainfrom
timeline-badge-bg

Conversation

@simurai

@simurai simurai commented Aug 26, 2021 •

Copy link
Copy Markdown
Contributor

This changes the timeline-badge-bg from canvas.subtle to neutral.muted.

Before After
Screen Shot 2021-08-25 at 17 02 10 Screen Shot 2021-08-25 at 17 02 18

⚠️ Warning: This change depends on primer/css#1550 (@primer/css@17.6.1). To make sure the line underneath is not visible.


Reported in https://github.com/github/design-infrastructure/discussions/1458#discussioncomment-1221757

@simurai
simurai requested a review from auareyou August 26, 2021 02:58
@simurai
simurai requested a review from a team as a code owner August 26, 2021 02:58
@simurai
simurai requested review from jonrohan and removed request for a team August 26, 2021 02:58
@changeset-bot

changeset-bot Bot commented Aug 26, 2021 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: aaa62f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 26, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/n9qnVurDWi2BHLPhH3DyxsZ5xone
âś… Preview: https://primitives-git-timeline-badge-bg-primer.vercel.app

@jonrohan jonrohan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@simurai
simurai merged commit 8e003a9 into main Aug 26, 2021
@simurai
simurai deleted the timeline-badge-bg branch August 26, 2021 05:38
@primer-css primer-css mentioned this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants