Repository navigation
Underline nav contrast improvements - #186
Merged
Merged
Conversation
Based on this feedback I https://github.com/github/github/discussions/183946#discussioncomment-1051866 - Unified icon color - Increased border hover contrast which was reported as well as an issue. - Mapped coral to scale
🦋 Changeset detectedLatest commit: 5198cfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/Fe8SkXnbzQYtv43tuAdU22hiWwDA |
simurai
requested changes
Jul 27, 2021
| border: alpha(get('scale.gray.6'), 0), | ||
| borderHover: get('scale.gray.6'), | ||
| borderActive: '#f78166', | ||
| borderActive: get('scale.coral.3'), |
Contributor
There was a problem hiding this comment.
I think this needs to be changed back to the hex value since the coral scale was only added to colors_v2 and doesn't exist in v1.
simurai
approved these changes
Jul 27, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on this feedback I
Mapped coral to scale