Skip to content

Increase <code> contrast - #185

Merged
simurai merged 2 commits into
mainfrom
markdown-code-bg
Jul 27, 2021
Merged

simurai merged 2 commits into
mainfrom
markdown-code-bg

Conversation

@simurai

@simurai simurai commented Jul 27, 2021

Copy link
Copy Markdown
Contributor

This increases the background contrast for these code blocks by using neutral.muted instead of neutral.subtle.

Theme Before After
Light Screen Shot 2021-07-27 at 16 20 21 Screen Shot 2021-07-27 at 16 20 32
Dark Screen Shot 2021-07-27 at 16 20 45 Screen Shot 2021-07-27 at 16 20 55
Dark Dimmed Screen Shot 2021-07-27 at 16 21 13 Screen Shot 2021-07-27 at 16 21 24
Dark High Contrast Screen Shot 2021-07-27 at 16 21 41 Screen Shot 2021-07-27 at 16 21 51

Reported in 1 + 2

@changeset-bot

changeset-bot Bot commented Jul 27, 2021 •

Copy link
Copy Markdown

πŸ¦‹ Changeset detected

Latest commit: 6750323

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jul 27, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/primer/primitives/72dhw3c89y8fGHEXqAowzqqJbTRe
βœ… Preview: https://primitives-git-markdown-code-bg-primer.vercel.app

@auareyou auareyou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! πŸ‘

@simurai
simurai merged commit b39f016 into main Jul 27, 2021
@simurai
simurai deleted the markdown-code-bg branch July 27, 2021 23:16
@github-actions github-actions Bot mentioned this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants