Repository navigation
neutral.emphasis fix - #158
Merged
Merged
Conversation
- Neutral emphasis is gray.5 by default - Only in HC it’s gray.4 (exception)
🦋 Changeset detectedLatest commit: cd0c90e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/3kV33T4zhy6zcufcEpC3PbZers1V |
Juliusschaeper
marked this pull request as draft
June 21, 2021 14:07
I realized that there is no need for a HC exception for neutral.emphasis, since using gray.4 across dark, dimmed and high contrast works because of the inverted emphasis in high contrast.
Juliusschaeper
marked this pull request as ready for review
June 21, 2021 14:18
simurai
approved these changes
Jun 21, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed wrong HC exception for neutral.emphasis.