Repository navigation
Fix formatting of storybook:install script in package.json - #1388
Conversation
🦋 Changeset detectedLatest commit: 928419f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the postinstall hook to prevent Storybook dependency installation from running for package consumers, keeping it as a local-development-only step.
Changes:
- Removed
postinstallscript that triggeredstorybook:installduring installs. - Kept
storybook:installas an explicit, opt-in script for local development. - Added a changeset to publish the removal as a patch.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removes postinstall and fixes scripts/object formatting to avoid consumer install side effects. |
| .changeset/funny-foxes-deliver.md | Adds a patch changeset documenting the removal of postinstall. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
|
FYI @lukasoppermann I think the project can be updated to use npm workspaces so that dependencies are setup automatically if that helps |
|
@joshblack I tried it and ran into issues. If you can get it to work, feel free to do so, that would be nice. |
Closes #1386
Remove the
postinstallhook as this causes issues when using the package. This is only for local development and should not be included in the published package.