Repository navigation
Change primitives.css to use imports - #1247
Conversation
🦋 Changeset detectedLatest commit: e5e19d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CSS build system to use imports in primitives.css and re-enables viewport.css. The change simplifies CSS loading by consolidating multiple imports into a single primitives.css file and restores viewport styles that were previously excluded.
- Modified build script to generate import statements instead of concatenating CSS content
- Re-enabled viewport.css by commenting out its exclusion filter
- Updated Storybook preview to use the consolidated primitives.css import
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/buildTokens.ts | Modified to generate CSS imports and re-enable viewport.css in the build |
| docs/storybook/.storybook/preview.css | Simplified to use single primitives.css import instead of multiple individual imports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@lukasoppermann yeah, the viewports export uses a special syntax that requires a PostCSS plugin to consume, so it feels risky to put it in an index. |
d663fd8 to
f5bb2d6
Compare
Summary
Change primitives.css to use imports
and add viewport.cssThis is one step in https://github.com/github/primer/issues/4506
@langermank is there any reason you removed viewports from primer.css? It is added in dotcom in the
index.scssList of notable changes:
What should reviewers focus on?
Steps to test: