Repository navigation
Added border.subtle to the global variables - #116
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 055194d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primitives/9xeJnWq8j6A8VcA9Dw4cd1yxZ2uH |
Pointed variables that can point to `get(’border.blend’)
border.blend to the global variablesborder.subtle to the global variables
colebemis
reviewed
Jun 1, 2021
Co-authored-by: Cole Bemis <colebemis@github.com>
colebemis
reviewed
Jun 1, 2021
colebemis
reviewed
Jun 1, 2021
Co-authored-by: Cole Bemis <colebemis@github.com>
Co-authored-by: Cole Bemis <colebemis@github.com>
auareyou
marked this pull request as ready for review
June 1, 2021 15:30
colebemis
reviewed
Jun 1, 2021
colebemis
reviewed
Jun 1, 2021
colebemis
reviewed
Jun 1, 2021
colebemis
reviewed
Jun 1, 2021
Co-authored-by: Cole Bemis <colebemis@github.com>
colebemis
reviewed
Jun 1, 2021
Co-authored-by: Cole Bemis <colebemis@github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition
I'm adding this variable to the global group because I want to test how far it can get us in replacing component-level variables. I suspect it will simplify:
Also introduces these types of borders as the standard to help backgrounds stand out from the canvases.
Examples
Naming
I'm oscilating betweenborder.blendwhich describes the use case more accurately andborder.onEmphasiswhich isn't fully accurate but is consistent with our naming.Trying to go wuth
border.subtleto follow the same structure