Skip to content

Repository navigation

Add 100ms duration - #1149

Merged
lukasoppermann merged 1 commit into
mainfrom
add-100ms-duration
Dec 24, 2024
Merged

Add 100ms duration#1149
lukasoppermann merged 1 commit into
mainfrom
add-100ms-duration

Conversation

@lukasoppermann

@lukasoppermann lukasoppermann commented Dec 24, 2024

Copy link
Copy Markdown
Collaborator

Summary

Adds 100ms duration, to make it easier to build short transitions with matching delays

@lukasoppermann
lukasoppermann requested review from a team as code owners December 24, 2024 09:20
@changeset-bot

changeset-bot Bot commented Dec 24, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 38e8b64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

Design Token Diff (CSS)

/css/base/motion/motion.css

 
+++ /home/runner/work/primitives/primitives/dist/css/base/motion/motion.css	2024-12-24 09:21:11.508457519 +0000
@@ -1,5 +1,6 @@
:root {
 --base-duration-0: 0ms;
+  --base-duration-100: 100ms;
 --base-duration-1000: 1s;
 --base-duration-200: 200ms;
 --base-duration-300: 300ms;

/css/primitives.css

 
+++ /home/runner/work/primitives/primitives/dist/css/primitives.css	2024-12-24 09:21:11.714460375 +0000
@@ -1,5 +1,6 @@
:root {
 --base-duration-0: 0ms;
+  --base-duration-100: 100ms;
 --base-duration-1000: 1s;
 --base-duration-200: 200ms;
 --base-duration-300: 300ms;

@github-actions

github-actions Bot commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

Design Token Diff (StyleLint)

/styleLint/base/motion/motion.json

 
+++ /home/runner/work/primitives/primitives/dist/styleLint/base/motion/motion.json	2024-12-24 09:21:11.508457519 +0000
@@ -13,6 +13,20 @@
   "path": ["base", "duration", "0"],
   "key": "{base.duration.0}"
 },
+  "base-duration-100": {
+    "$value": "100ms",
+    "$type": "duration",
+    "filePath": "src/tokens/base/motion/timing.json5",
+    "isSource": true,
+    "original": {
+      "$value": "100ms",
+      "$type": "duration"
+    },
+    "name": "base-duration-100",
+    "attributes": {},
+    "path": ["base", "duration", "100"],
+    "key": "{base.duration.100}"
+  },
 "base-duration-1000": {
   "$value": "1000ms",
   "$type": "duration",

@github-actions

github-actions Bot commented Dec 24, 2024

Copy link
Copy Markdown
Contributor

Design Token Diff (Fallbacks)

/fallbacks/base/motion/motion.json

 
+++ /home/runner/work/primitives/primitives/dist/fallbacks/base/motion/motion.json	2024-12-24 09:21:11.508457519 +0000
@@ -5,6 +5,7 @@
 "--base-easing-easeInOut": [0.6, 0, 0.2, 1],
 "--base-duration-0": "0ms",
 "--base-duration-75": "75ms",
+  "--base-duration-100": "100ms",
 "--base-duration-200": "200ms",
 "--base-duration-300": "300ms",
 "--base-duration-400": "400ms",

@github-actions
github-actions Bot temporarily deployed to Preview (Storybook) December 24, 2024 09:22 Inactive
@lukasoppermann
lukasoppermann merged commit 24aa6fc into main Dec 24, 2024
@lukasoppermann
lukasoppermann deleted the add-100ms-duration branch December 24, 2024 09:33
@primer primer Bot mentioned this pull request Dec 24, 2024
Merged

This branch was previously deployed

2 inactive deployments
Preview (Storybook) — 38e8b643 Deployed Dec 24, 2024 by github-actions[bot]
github-pages — 38e8b643 Deployed Dec 24, 2024 by lukasoppermann
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan was automatically assigned from primer/css-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lukasoppermann