Skip to content

Save shield-slash-24.svg - #924

Merged
colebemis merged 4 commits into
mainfrom
shield-slash-24
Mar 1, 2023
Merged

colebemis merged 4 commits into
mainfrom
shield-slash-24

Conversation

@CameronFoxly

Copy link
Copy Markdown
Contributor

Adding the 24px version of shield-slash, requested in this issue.

@CameronFoxly
CameronFoxly requested a review from a team as a code owner February 28, 2023 19:44
@CameronFoxly
CameronFoxly requested a review from gavinmn February 28, 2023 19:44
@changeset-bot

changeset-bot Bot commented Feb 28, 2023 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 78a877d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gavinmn gavinmn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think this one is suffering from the "sliding top half" more than the 16px version, but we haven't found a good solution for addressing this issue quite yet.

@colebemis
colebemis merged commit 6b494df into main Mar 1, 2023
@colebemis
colebemis deleted the shield-slash-24 branch March 1, 2023 19:23
@primer-css primer-css mentioned this pull request Mar 1, 2023

This branch was successfully deployed

1 active deployment
github-pages — 78a877d4 Deployed Feb 28, 2023 by CameronFoxly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants