Skip to content

Add sidebar expand and collapse icons - #569

Merged
colebemis merged 2 commits into
release-13.0.0from
sidebar-icons
Apr 2, 2021
Merged

colebemis merged 2 commits into
release-13.0.0from
sidebar-icons

Conversation

@colebemis

Copy link
Copy Markdown
Contributor

image

@vercel

vercel Bot commented Mar 31, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/primer/octicons/EYFVPCNWDtJTEn1n7GTCT6mzp3Fb
βœ… Preview: https://octicons-git-sidebar-icons-primer.vercel.app

@ashygee

ashygee commented Mar 31, 2021

Copy link
Copy Markdown
Contributor

@colebemis is collapse and expand the correct descriptor for this? not open/close?

@colebemis

Copy link
Copy Markdown
Contributor Author

@ashygee I'm fine with either.

@colebemis

Copy link
Copy Markdown
Contributor Author

expand/collapse feel like they represent the action of "expanding" or "collapsing" which is how the icons will be used. open/close feel more like they could be states of the sidebar.

@ashygee
ashygee requested a review from pmarsceill March 31, 2021 17:32
@ashygee ashygee mentioned this pull request Apr 1, 2021
14 tasks done
@ashygee

ashygee commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

expand/collapse feel like they represent the action of "expanding" or "collapsing" which is how the icons will be used. open/close feel more like they could be states of the sidebar.

This makes perfect sense. let's keep as is then! πŸš€ it!

@colebemis
colebemis changed the base branch from master to release-13.0.0 April 2, 2021 16:11
@colebemis
colebemis merged commit dcb4c1b into release-13.0.0 Apr 2, 2021
@colebemis
colebemis deleted the sidebar-icons branch April 2, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants