Skip to content

Adds infinity, line-arrow, and heart-outline symbols, cleans up heart icon path - #365

Closed
superbryntendo wants to merge 1 commit into
primer:masterfrom
superbryntendo:patch-1
Closed

Adds infinity, line-arrow, and heart-outline symbols, cleans up heart icon path#365
superbryntendo wants to merge 1 commit into
primer:masterfrom
superbryntendo:patch-1

Conversation

@superbryntendo

@superbryntendo superbryntendo commented Jan 7, 2020

Copy link
Copy Markdown
title image description
heart glyph updates image Outlining the heart in the glyph vs via css enables the stroke to be centered on the path without increasing the glyph frame dimensions. Regardless of stroking method, the inset point needs to be slightly rounded or the angle increases in an awkward manner. This also updates the vertical centering in the frame to make it easier to align with text.
heart glyph diff detail image There were a few unnecessary points on the path with some misaligned beziers that made it slightly bumpy, rather than smooth.
infinity glyph (proposal/rationale) image This is for use on pricing pages for features marked as "unlimited" (e.g. contributors, repos, etc.)
line-arrow glyphs image These are based on the caret/chevron symbols and are used on pricing pages to denote "<- contains all of these features". We also use the up arrow on small screens when the plans reorient to be vertically-listed.

cc @katmeister

@ashygee

ashygee commented Jan 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

HI @superbryntendo sorry for the delay on this. Just wanted to get a few more details before we put these in the next release.

A few things to note before we put in these updates:

  1. the sponsors hearts will need to be updated to use 2 separate icons instead of just CSS. @katmeister do you know who would be best to make aware of this change after these new octicons go out?
  2. would you be able to swap the naming convention to prepare for the future update? (heart/heart-fill instead of heart/heart-outline)

Also for the addition of the infinity and line-arrows who should we notify to swap out the SVGs with the octicons after the release?

Thanks again for making these updates!!!

@superbryntendo

superbryntendo commented Jan 14, 2020

Copy link
Copy Markdown
Author

I've changed the heart naming scheme.

Can't mention github teams directly here, but pe-nux manages the pages they're implemented on now. site-design has used a 3rd-party icon set to get these glyphs for the pricing page. Hopefully this should allow them to switch over as well.

@katmeister

katmeister commented Jan 14, 2020

Copy link
Copy Markdown
Contributor
  1. do you know who would be best to make aware of this change after these new octicons go out?

@ashygee That would be me! πŸ˜„

2. would you be able to swap the naming convention to prepare for the future update? (heart/heart-fill instead of heart/heart-outline)

Ah, so there will be a separate icon for the outlined heart? Sure, I can prepare for that. What's the timeline for the next release?

@ashygee

ashygee commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

Ah, so there will be a separate icon for the outlined heart? Sure, I can prepare for that. What's the timeline for the next release?

I will work with @jonrohan together at the end of the week and we should be able to get this set for next week.

@simurai
simurai requested review from ashygee and jonrohan January 29, 2020 07:36
@jonrohan jonrohan mentioned this pull request Jan 29, 2020
Merged
3 of 4 tasks
@jonrohan

jonrohan commented Jan 29, 2020

Copy link
Copy Markdown
Member

Going in release 9.4.0 #368

@jonrohan jonrohan closed this Jan 29, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashygee ashygee Awaiting requested review from ashygee
@jonrohan jonrohan Awaiting requested review from jonrohan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@superbryntendo @ashygee @katmeister @jonrohan