Skip to content

Fix VSCode icon and remove unnecessary size variants - #1208

Merged
TylerJDev merged 3 commits into
mainfrom
dats/vscode
May 29, 2026
Merged

TylerJDev merged 3 commits into
mainfrom
dats/vscode

Conversation

@dylanatsmith

Copy link
Copy Markdown
Member

The existing vscode icons are misaligned. We also don’t need 32 or 48px variants; 16px and 24px suffice for in-product usage, and I don’t see any existing instances of the other sizes.

Size Before After
16px image image
24px image
32px image

@dylanatsmith dylanatsmith self-assigned this May 15, 2026
Copilot AI review requested due to automatic review settings May 15, 2026 16:09
@dylanatsmith
dylanatsmith requested a review from a team as a code owner May 15, 2026 16:09
@changeset-bot

changeset-bot Bot commented May 15, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 14970fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the VSCode Octicon assets to fix alignment, adds a 24px variant, and removes larger variants no longer intended for product usage.

Changes:

  • Replaces the 16px VSCode SVG path.
  • Adds a new 24px VSCode SVG.
  • Removes 32px and 48px VSCode SVG variants and adds a changeset.
Show a summary per file
File Description
icons/vscode-16.svg Updates the 16px VSCode icon artwork.
icons/vscode-24.svg Adds a 24px VSCode icon variant.
icons/vscode-32.svg Removes the 32px VSCode icon variant.
icons/vscode-48.svg Removes the 48px VSCode icon variant.
.changeset/add-vscode-icon.md Documents the icon update for release.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/5 changed files
  • Comments generated: 1

Comment thread .changeset/add-vscode-icon.md Resolved
@joshblack
joshblack requested review from TylerJDev and removed request for francinelucca May 18, 2026 18:08
@TylerJDev
TylerJDev merged commit eddab3f into main May 29, 2026
11 checks passed
@TylerJDev
TylerJDev deleted the dats/vscode branch May 29, 2026 16:21
@primer primer Bot mentioned this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants