Allow handling a pch vector in new R version#11
Merged
Conversation
Contributor
|
Thanks for the PR. Sorry it took so long to get to it... |
Contributor
Author
|
Thank you! And have a good day :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent R versions throw errors when supplying plotCI() with a pch argument that is a vector. This is because the if condition on line 39 cannot handle a vector (anymore). Surrounding the is.na() in this line with an any() call prevents this problem. This way, plotCI() can still be used with a vector pch argument in newer R versions.