Fix logic associated with WP_REDIS_IGNORE_GLOBAL_GROUPS#333
Merged
Conversation
The array hasn't been run through `array_fill_keys()` yet, so need to inspect the array values
Contributor
Author
|
@JanThiel FYI - your original logic was broken ^^ |
Contributor
|
@danielbachhuber Strange ... I have this working with But thanks for fixing and letting me know. |
Contributor
|
But you are absolutely right ... at this point, there are no key => value pairs. |
Contributor
Author
|
No worries 😄 Thanks again for the pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The array hasn't been run through
array_fill_keys()yet, so need toinspect the array values