Allow external reviewers to "resolve" their own comments #212045
Unanswered
Marcono1234
asked this question in
Pull Requests
Replies: 1 comment
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Product Feedback
Body
While you can as non-member of a repository submit review comments on pull requests, you cannot yourself "resolve" (button "Resolve conversation") your own comments.
This is also mentioned in the documentation (emphasis mine):
This is quite inconvenient because:
Requested feature: The author of a PR review comment should always be able to resolve their own comment, even if the comment author is an external user and neither a repository member nor the PR author.
Consideration: Maybe there are rare cases where the current behavior is desired, e.g. when the external review comment mirrors what a repository member would have commented (and therefore the member did not add an additional comment). So in that case maybe only the repository member wants to mark it as resolved.
But this is a pretty weak argument: The external reviewer could just delete their comment and it would be gone as well; or the PR author could mark it as resolved despite the repository member disagreeing. So whether the external reviewer can resolve their own comment would not make a big difference.
All reactions