use_proxy(): Add missing terminating NUL byte

t8m · t8m · commit 654dc11d2346 · 2025-09-29T12:04:46.000+02:00
Fixes CVE-2025-9232 There is a missing terminating NUL byte after strncpy() call. Issue and a proposed fix reported by Stanislav Fort (Aisle Research). Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (cherry picked from commit 6bca150)
diff --git a/crypto/http/http_lib.c b/crypto/http/http_lib.c
@@ -267,6 +267,7 @@ static int use_proxy(const char *no_proxy, const char *server)
         /* strip leading '[' and trailing ']' from escaped IPv6 address */
         sl -= 2;
         strncpy(host, server + 1, sl);
+        host[sl] = '\0';
         server = host;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -267,6 +267,7 @@ static int use_proxy(const char no_proxy, const char server)`
`267`	`267`	`/* strip leading '[' and trailing ']' from escaped IPv6 address */`
`268`	`268`	`sl -= 2;`
`269`	`269`	`strncpy(host, server + 1, sl);`
	`270`	`+ host[sl] = '\0';`
`270`	`271`	`server = host;`
`271`	`272`	`}`
`272`	`273`