fix(terminal): preserve sibling home-prefix paths by qingminglong · Pull Request #98876 · openclaw/openclaw

qingminglong · 2026-07-02T03:21:13Z

What Problem This Solves

Terminal table rendering globally replaced the effective home string, so sibling or embedded paths that merely shared that prefix could be corrupted. For example, /home/alice2/project could display as ~2/project when the effective home was /home/alice.

Why This Change Was Made

displayString now scans home occurrences and replaces only values with a real left token boundary plus one of these right boundaries:

end of the value
a / or \\ child-path separator
a terminal punctuation run followed by whitespace or end of input

This preserves whole-home and child-path shortening, including labeled table values, while rejecting sibling prefixes, embedded longer paths, space-suffixed siblings, comma-suffixed siblings, and punctuation runs that continue into a path. The detailed cases live beside displayString; renderTable keeps one integration test.

User Impact

Terminal tables no longer show misleading paths such as ~2/project or /tmp~/project. Exact home paths, child paths, and complete home tokens before terminal punctuation still use ~ or $OPENCLAW_HOME.

Evidence

Exact repaired head: de0ff5fdf7f538594197830b1647895cf3c65064
node scripts/run-vitest.mjs packages/terminal-core/src/display-string.test.ts packages/terminal-core/src/table.test.ts: 27/27 tests passed
./node_modules/.bin/oxfmt --check ... and ./node_modules/.bin/oxlint ...: passed for all three changed files
Fresh autoreview after accepted boundary fixes: no findings, confidence 0.91
Blacksmith Testbox tbx_01kwgwkdma74r1frdw64pn1ark, Actions run 28573967242: remote check:changed passed the core and coreTests lanes with exit 0
Exact-head GitHub CI: 61 passing checks, 0 pending, 0 failing; two initial workflow-sanity checkout failures were rerun successfully after GitHub returned HTTP 429
Known scope boundary: src/utils.ts has a broader public/plugin-SDK helper with similar prefix behavior; it is intentionally excluded from this narrow terminal-core fix and needs a separate clean follow-up

clawsweeper · 2026-07-02T03:31:38Z

Codex review: needs maintainer review before merge. Reviewed July 2, 2026, 3:28 AM ET / 07:28 UTC.

Summary
The PR replaces terminal-core table-cell home-path substitution with boundary-aware replacement and adds renderTable regressions for exact, child, sibling, embedded, punctuated, and OPENCLAW_HOME cases.

PR surface: Source +34, Tests +66. Total +100 across 2 files.

Reproducibility: yes. Source inspection shows current main uses global home-string replacement and renderTable applies it to every table cell, so a HOME=/home/alice cell containing /home/alice2/project follows the reported failure path.

Review metrics: none identified.

Root-cause cluster
Relationship: fixed_by_candidate
Canonical: #98872
Summary: This PR is the active candidate fix for the linked terminal table home-prefix display bug; related helper and session PRs overlap but do not supersede this terminal-core change.

Members:

canonical: [Bug]: Terminal table display rewrites paths that only share the home directory prefix #98872 - The PR body closes the issue that reports the exact terminal table sibling-prefix display behavior.
partial_overlap: Fix home path replacement in shortenHomeInString utility #88449 - That open PR targets the broader src/utils shortening helper and is currently conflicting, so it does not replace this terminal-core-specific fix.
partial_overlap: fix(sessions): keep sibling dirs that share the home prefix unshortened in tool path display #96562 - That merged PR fixed the same home-prefix class in session tool path display, but it touched a different helper and did not fix terminal-core table rendering.
superseded: fix: avoid shortening home path substrings #96398 - That older terminal-core attempt was closed unmerged after newer issue-linked replacement work appeared.
superseded: fix(utils): only shorten home dir when followed by path separator (#98872) #98885 - That closed unmerged utility-only attempt does not provide a viable replacement for this active terminal-core PR.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

none.

Next step before merge

No automated repair lane is needed because the PR already implements the narrow fix and has no actionable review finding; maintainers should proceed with normal review or landing.

Security
Cleared: The diff is limited to terminal display-formatting TypeScript and tests, with no dependency, workflow, secret, package, or supply-chain surface change.

Review details

Best possible solution:

Land this terminal-core boundary fix after ordinary maintainer review and CI; keep broader src/utils helper behavior tracked separately by the existing helper-focused PR if maintainers want that surface changed too.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection shows current main uses global home-string replacement and renderTable applies it to every table cell, so a HOME=/home/alice cell containing /home/alice2/project follows the reported failure path.

Is this the best way to solve the issue?

Yes. The PR fixes the implicated terminal-core displayString path with boundary-aware matching and table-level regression coverage; changing the broader src/utils helper is a separate surface, not required for this terminal-table bug.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against d32c4cf3007f.

Label changes

Label justifications:

P2: The PR addresses a user-visible terminal output correctness bug with limited blast radius and no config, persistence, provider, or security surface.
rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The PR body includes after-fix live renderTable output from the changed terminal-core path showing corrected exact, child, and sibling path display behavior.
proof: sufficient: Contributor real behavior proof is sufficient. The PR body includes after-fix live renderTable output from the changed terminal-core path showing corrected exact, child, and sibling path display behavior.

Evidence reviewed

PR surface:

Source +34, Tests +66. Total +100 across 2 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	1	35	1	+34
Tests	1	67	1	+66
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	2	102	2	+100

What I checked:

Repository policy read: Root AGENTS.md was read fully and applied to the deep, read-only PR review; no scoped packages/AGENTS.md or matching maintainer note was present for the touched path. (AGENTS.md:1, d32c4cf3007f)
Current-main bug path: Current main still resolves the effective home display prefix and then replaces every occurrence of the home string with split/join, so sibling prefixes can be shortened incorrectly. (packages/terminal-core/src/display-string.ts:82, d32c4cf3007f)
Runtime caller: renderTable applies displayString to every table cell value before rendering, matching the linked issue's user-visible terminal table surface. (packages/terminal-core/src/table.ts:431, d32c4cf3007f)
PR implementation: PR head adds replaceHomePath and checks both the character before and after the matched home string before substituting the display prefix. (packages/terminal-core/src/display-string.ts:77, 0a203b133346)
Regression coverage: PR head adds renderTable coverage for exact home paths, slash and backslash child paths, sibling-prefix paths, embedded prefixes, label/value text, punctuation and space siblings, and OPENCLAW_HOME prefixes. (packages/terminal-core/src/table.test.ts:181, 0a203b133346)
Latest release behavior: The latest release tag still contains the same unbounded split/join implementation in terminal-core, so the linked bug is not already fixed in the shipped release. (packages/terminal-core/src/display-string.ts:82, e085fa1a3ffd)

Likely related people:

steipete: Current-line blame and PR metadata tie the terminal-core displayString/table files to commit 27104c1 from merged fix(codex): preserve plugin app approvals in side conversations #98812. (role: introduced current terminal-core display path; confidence: high; commits: 27104c1afb13; files: packages/terminal-core/src/display-string.ts, packages/terminal-core/src/table.ts, packages/terminal-core/src/table.test.ts)
Seb Slight: Commit db137dd implemented OPENCLAW_HOME-aware path resolution in src/utils.ts and related path tests, which is adjacent to the display-prefix contract copied into terminal-core. (role: adjacent path-resolution contributor; confidence: medium; commits: db137dd65da0; files: src/utils.ts, src/utils.test.ts, src/infra/home-dir.ts)
vincentkoc: The current live PR is assigned to vincentkoc, making them a practical routing candidate even though the code-history signal points elsewhere. (role: likely follow-up owner; confidence: medium; files: packages/terminal-core/src/display-string.ts, packages/terminal-core/src/table.test.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

qingminglong · 2026-07-02T03:52:20Z

Updated the PR body Evidence after the follow-up boundary fix. Added left-boundary handling, label/separator regression coverage, and fresh focused proof: node scripts/run-vitest.mjs packages/terminal-core/src/table.test.ts passed 26 tests, git diff --check passed, and autoreview is clean. @clawsweeper re-review

qingminglong · 2026-07-02T04:08:20Z

Updated the PR body Evidence again to remove the stale missing-dependency proof gap and add direct renderTable output from the changed terminal-core path. The body now includes the exact focused test result, git diff --check, autoreview, and real table output showing exact/child home paths shortened while sibling and embedded paths remain unchanged. @clawsweeper re-review

qingminglong · 2026-07-02T04:21:31Z

Pushed a boundary follow-up and refreshed the PR body Evidence. The new head preserves exact/child home shortening, allows prose exact-home tokens like Home: <home>,, and keeps punctuated/space-suffixed sibling paths unchanged. Fresh proof: node scripts/run-vitest.mjs packages/terminal-core/src/table.test.ts passed 26 tests, git diff --check passed, pnpm exec oxlint packages/terminal-core/src/display-string.ts packages/terminal-core/src/table.test.ts passed, and the body includes direct renderTable output. Latest autoreview attempt timed out, so I did not claim it passed. @clawsweeper re-review

vincentkoc · 2026-07-02T08:11:38Z

maintainer repair and pre-merge proof complete on de0ff5fdf7f538594197830b1647895cf3c65064.

replaced global home-string substitution with explicit left/right token-boundary checks
preserved exact home, child paths, labeled values, terminal punctuation, and $OPENCLAW_HOME
added negative coverage for sibling prefixes, space/comma suffixes, embedded longer paths, and punctuation runs that continue into paths
focused local proof: node scripts/run-vitest.mjs packages/terminal-core/src/display-string.test.ts packages/terminal-core/src/table.test.ts passed 27/27
formatter, lint, and git diff --check passed on the three changed files
fresh autoreview after accepting and fixing two boundary findings: no findings, confidence 0.91
Blacksmith Testbox tbx_01kwgwkdma74r1frdw64pn1ark, Actions run 28573967242: raw-sync check:changed passed core and coreTests, exit 0
exact-head GitHub CI: 61 passing, 0 pending, 0 failing
Workflow Sanity run 28574317788 initially hit GitHub checkout HTTP 429; the complete rerun passed and now records top-level success
native scripts/pr review-validate-artifacts 98876 and OPENCLAW_TESTBOX=1 scripts/pr prepare-run 98876 passed

known scope boundary: the broader public/plugin-SDK helper in src/utils.ts remains separate work; mixing it here would widen the compatibility surface beyond #98872.

vincentkoc · 2026-07-02T08:11:57Z

Merged via squash.

Prepared head SHA: de0ff5fdf7f538594197830b1647895cf3c65064
Landed commit: c170e91529eaf0d9582061366992d764e339f516

…diagnostics Replace text.split(homePath).join('~') with replaceHomePathInText() that checks token boundaries before substituting home paths, preventing sibling path corruption (same bug pattern as openclaw#98876). Real behavior proof: Input: "Error in /home/user2/project: file not found at /home/user/config.json" OLD: "Error in ~2/project: file not found at ~/config.json" <- corrupted NEW: "Error in /home/user2/project: file not found at ~/config.json" Co-Authored-By: Claude <noreply@anthropic.com>

* fix(terminal): preserve sibling home-prefix paths * fix(terminal): avoid embedded home path rewrites * fix(terminal): preserve punctuated sibling paths * fix(terminal): tighten home path boundaries

openclaw-barnacle Bot added the size: S label Jul 2, 2026

maweibin mentioned this pull request Jul 2, 2026

fix(utils): only shorten home dir when followed by path separator (#98872) #98885

Closed

github-actions Bot mentioned this pull request Jul 2, 2026

🦞 OpenClaw 生态日报 2026-07-02 96loveslife/big_model_radar#91

Open

vincentkoc self-assigned this Jul 2, 2026

qingminglong added 4 commits July 2, 2026 00:43

fix(terminal): preserve sibling home-prefix paths

0861a7d

fix(terminal): avoid embedded home path rewrites

ffa05c0

fix(terminal): preserve punctuated sibling paths

02b06e6

fix(terminal): tighten home path boundaries

de0ff5f

vincentkoc force-pushed the codex/issue-98872-terminal-home-display branch from 0a203b1 to de0ff5f Compare July 2, 2026 07:49

vincentkoc merged commit c170e91 into openclaw:main Jul 2, 2026
90 of 94 checks passed

github-actions Bot mentioned this pull request Jul 2, 2026

📡 Upstream Digest — 2026-07-02 10:29 UTC curtismercier/openclaw-mods#1188

Open

cxbAsDev mentioned this pull request Jul 2, 2026

fix(browser): use boundary-aware home path replacement in chrome-mcp diagnostics #99112

Closed

cxbAsDev mentioned this pull request Jul 3, 2026

fix(session-memory): use shortenHomePath for safe home-path display in logs #99114

Closed

clawsweeper Bot mentioned this pull request Jul 6, 2026

Bug: Agent outputs ~ tilde shorthand instead of full absolute file paths #38430

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(terminal): preserve sibling home-prefix paths#98876

fix(terminal): preserve sibling home-prefix paths#98876
vincentkoc merged 4 commits into
openclaw:mainfrom
qingminglong:codex/issue-98872-terminal-home-display

qingminglong commented Jul 2, 2026 •

edited by vincentkoc

Loading

Uh oh!

clawsweeper Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

qingminglong commented Jul 2, 2026

Uh oh!

qingminglong commented Jul 2, 2026

Uh oh!

qingminglong commented Jul 2, 2026

Uh oh!

vincentkoc commented Jul 2, 2026

Uh oh!

Uh oh!

vincentkoc commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

qingminglong commented Jul 2, 2026 • edited by vincentkoc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Why This Change Was Made

User Impact

Evidence

Uh oh!

clawsweeper Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qingminglong commented Jul 2, 2026

Uh oh!

qingminglong commented Jul 2, 2026

Uh oh!

qingminglong commented Jul 2, 2026

Uh oh!

vincentkoc commented Jul 2, 2026

Uh oh!

Uh oh!

vincentkoc commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

qingminglong commented Jul 2, 2026 •

edited by vincentkoc

Loading

clawsweeper Bot commented Jul 2, 2026 •

edited

Loading